pgbench: If we fail to send a command to the server, fail.

robertmhaas · robertmhaas · commit e55d9643ecb8 · 2017-09-29T13:55:38.000-04:00
This beats the old behavior of busy-waiting hands down. Oversight in commit 12788ae. Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed by Pavan Deolasee. Discussion: http://postgr.es/m/CABOikdPhfXTypckMC1Ux6Ko+hKBWwUBA=EXsvamXYSg8M9J94w@mail.gmail.com
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -2194,12 +2194,8 @@ doCustom(TState *thread, CState *st, StatsData *agg)
 				{
 					if (!sendCommand(st, command))
 					{
-						/*
-						 * Failed. Stay in CSTATE_START_COMMAND state, to
-						 * retry. ??? What the point or retrying? Should
-						 * rather abort?
-						 */
-						return;
+						commandFailed(st, "SQL command send failed");
+						st->state = CSTATE_ABORTED;
 					}
 					else
 						st->state = CSTATE_WAIT_RESULT;

Original file line number	Diff line number	Diff line change
`@@ -2194,12 +2194,8 @@ doCustom(TState thread, CState st, StatsData *agg)`
`2194`	`2194`	`{`
`2195`	`2195`	`if (!sendCommand(st, command))`
`2196`	`2196`	`{`
`2197`		`- /*`
`2198`		`- * Failed. Stay in CSTATE_START_COMMAND state, to`
`2199`		`- * retry. ??? What the point or retrying? Should`
`2200`		`- * rather abort?`
`2201`		`- */`
`2202`		`- return;`
	`2197`	`+ commandFailed(st, "SQL command send failed");`
	`2198`	`+ st->state = CSTATE_ABORTED;`
`2203`	`2199`	`}`
`2204`	`2200`	`else`
`2205`	`2201`	`st->state = CSTATE_WAIT_RESULT;`