8000 Suppress more variable-set-but-not-used warnings from clang 15. · postgres/postgres@bb8dbc9 · GitHub
[go: up one dir, main page]
Skip to content

Commit bb8dbc9

Browse files
tglsfdctglsfdc
committed
Suppress more variable-set-but-not-used warnings from clang 15.
Mop up assorted set-but-not-used warnings in the back branches. This includes back-patching relevant fixes from commit 152c9f7 the rest of the way, but there are also several cases that did not appear in HEAD. Some of those we'd fixed in a retail way but not back-patched, and others I think just got rewritten out of existence during nearby refactoring. While here, also back-patch b1980f6 (PL/Tcl: Fix compiler warnings with Tcl 8.6) into 9.2, so that that branch compiles warning-free with modern Tcl. Per project policy, this is a candidate for back-patching into out-of-support branches: it suppresses annoying compiler warnings but changes no behavior. Hence, back-patch all the way to 9.2. Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us
1 parent 9afdf39 commit bb8dbc9

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

‎src/backend/optimizer/util/var.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -699,16 +699,13 @@ flatten_join_alias_vars_mutator(Node *node,
699699
RowExpr *rowexpr;
700700
List *fields = NIL;
701701
List *colnames = NIL;
702-
AttrNumber attnum;
703702
ListCell *lv;
704703
ListCell *ln;
705704

706-
attnum = 0;
707705
Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames));
708706
forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames)
709707
{
710708
newvar = (Node *) lfirst(lv);
711-
attnum++;
712709
/* Ignore dropped columns */
713710
if (newvar == NULL)
714711
continue;

‎src/backend/utils/adt/varlena.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4370,7 +4370,6 @@ text_to_array_internal(PG_FUNCTION_ARGS)
43704370
* to search for occurrences of fldsep.
43714371
*/
43724372
TextPositionState state;
4373-
int fldnum;
43744373
int start_posn;
43754374
int end_posn;
43764375
int chunk_len;
@@ -4421,7 +4420,7 @@ text_to_array_internal(PG_FUNCTION_ARGS)
44214420
/* start_ptr points to the start_posn'th character of inputstring */
44224421
start_ptr = VARDATA_ANY(inputstring);
44234422

4424-
for (fldnum = 1;; fldnum++) /* field number is 1 based */
4423+
for (;;)
44254424
{
44264425
CHECK_FOR_INTERRUPTS();
44274426

‎src/backend/utils/cache/relcache.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4096,7 +4096,6 @@ AttrDefaultFetch(Relation relation)
40964096
HeapTuple htup;
40974097
Datum val;
40984098
bool isnull;
4099-
int found;
41004099
int i;
41014100

41024101
ScanKeyInit(&skey,
@@ -4107,7 +4106,6 @@ AttrDefaultFetch(Relation relation)
41074106
adrel = heap_open(AttrDefaultRelationId, AccessShareLock);
41084107
adscan = systable_beginscan(adrel, AttrDefaultIndexId, true,
41094108
NULL, 1, &skey);
4110-
found = 0;
41114109

41124110
while (HeapTupleIsValid(htup = systable_getnext(adscan)))
41134111
{
@@ -4122,8 +4120,6 @@ AttrDefaultFetch(Relation relation)
41224120
elog(WARNING, "multiple attrdef records found for attr %s of rel %s",
41234121
NameStr(attr->attname),
41244122
RelationGetRelationName(relation));
4125-
else
4126-
found++;
41274123

41284124
val = fastgetattr(htup,
41294125
Anum_pg_attrdef_adbin,

0 commit comments

Comments
 (0)
0