You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{"payload":{"commit":{"oid":"ba8321349bc02423aa4d49ebb5d579ec313cf930","url":"/postgres/postgres/commit/ba8321349bc02423aa4d49ebb5d579ec313cf930","authoredDate":"2022-08-23T09:55:05.000+07:00","committedDate":"2022-08-23T09:55:05.000+07:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eSwitch format specifier for replication origins to %d\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"Using %u with uint16 causes warnings with -Wformat-signedness. There are many\nother warnings, but for now change only these since \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/postgres/postgres/commit/c920fe48181d81ce218faa746f8af92c41d03b2e/hovercard\" href=\"https://github.com/postgres/postgres/commit/c920fe48181d81ce218faa746f8af92c41d03b2e\"\u003e\u003ctt\u003ec920fe4\u003c/tt\u003e\u003c/a\u003e already changed\nthe message string for most of them.\n\nPer report from Peter Eisentraut\nDiscussion: \u003ca href=\"https://www.postgresql.org/message-id/31e63649-0355-7088-831e-b07d5f908a8c%40enterprisedb.com\" rel=\"nofollow\"\u003ehttps://www.postgresql.org/message-id/31e63649-0355-7088-831e-b07d5f908a8c%40enterprisedb.com\u003c/a\u003e","authors":[{"login":"j-naylor","displayName":"John Naylor","avatarUrl":"https://avatars.githubusercontent.com/u/100744591?v=4","path":"/j-naylor","isGitHub":false}],"committerAttribution":false,"committer":{"login":"j-naylor","displayName":"John Naylor","avatarUrl":"https://avatars.githubusercontent.com/u/100744591?v=4","path":"/j-naylor","isGitHub":false},"parents":["1b9050da66aba821fec18376bee30d17e91e7027"],"globalRelayId":"C_kwDOAA4m0toAKGJhODMyMTM0OWJjMDI0MjNhYTRkNDllYmI1ZDU3OWVjMzEzY2Y5MzA","sha1":"1b9050da66aba821fec18376bee30d17e91e7027","sha2":"ba8321349bc02423aa4d49ebb5d579ec313cf930"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":363,"text":"@@ -364,7 +364,7 @@ replorigin_drop_guts(Relation rel, RepOriginId roident, bool nowait)","html":"@@ -364,7 +364,7 @@ replorigin_drop_guts(Relation rel, RepOriginId roident, bool nowait)","displayNoNewLineWarning":false,"position":0,"left":363,"right":363},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":364,"text":" \t\t\t\tif (nowait)","html":" \t\t\t\t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003enowait\u003c/span\u003e)","displayNoNewLineWarning":false,"position":1,"left":364,"right":364},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":365,"text":" \t\t\t\t\tereport(ERROR,","html":" \t\t\t\t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":2,"left":365,"right":365},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":366,"text":" \t\t\t\t\t\t\t(errcode(ERRCODE_OBJECT_IN_USE),","html":" \t\t\t\t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_OBJECT_IN_USE\u003c/span\u003e),","displayNoNewLineWarning":false,"position":3,"left":366,"right":366},{"stylingDirective":null,"type":"DELETION","blobLineNumber":367,"text":"-\t\t\t\t\t\t\t errmsg(\"could not drop replication origin with ID %u, in use by PID %d\",","html":"-\t\t\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not drop replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e, in use by PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":4,"left":367,"right":366},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":367,"text":"+\t\t\t\t\t\t\t errmsg(\"could not drop replication origin with ID %d, in use by PID %d\",","html":"+\t\t\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not drop replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e, in use by PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":5,"left":367,"right":367},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":368,"text":" \t\t\t\t\t\t\t\t\tstate-\u003eroident,","html":" \t\t\t\t\t\t\t\t\t\u003cspan class=pl-s1\u003estate\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eroident\u003c/span\u003e,","displayNoNewLineWarning":false,"position":6,"left":368,"right":368},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":369,"text":" \t\t\t\t\t\t\t\t\tstate-\u003eacquired_by)));","html":" \t\t\t\t\t\t\t\t\t\u003cspan class=pl-s1\u003estate\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eacquired_by\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":7,"left":369,"right":369},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":370,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":8,"left":370,"right":370},{"stylingDirective":null,"type":"HUNK","blobLineNumber":407,"text":"@@ -408,7 +408,7 @@ replorigin_drop_guts(Relation rel, RepOriginId roident, bool nowait)","html":"@@ -408,7 +408,7 @@ replorigin_drop_guts(Relation rel, RepOriginId roident, bool nowait)","displayNoNewLineWarning":false,"position":9,"left":407,"right":407},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":408,"text":" \t */","html":" \u003cspan class=pl-c\u003e\t */\u003c/span\u003e","displayNoNewLineWarning":false,"position":10,"left":408,"right":408},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":409,"text":" \ttuple = SearchSysCache1(REPLORIGIDENT, ObjectIdGetDatum(roident));","html":" \t\u003cspan class=pl-s1\u003etuple\u003c/span\u003e \u003cspan class=pl-c1\u003e=\u003c/span\u003e \u003cspan class=pl-en\u003eSearchSysCache1\u003c/span\u003e(\u003cspan class=pl-c1\u003eREPLORIGIDENT\u003c/span\u003e, \u003cspan class=pl-en\u003eObjectIdGetDatum\u003c/span\u003e(\u003cspan class=pl-s1\u003eroident\u003c/span\u003e));","displayNoNewLineWarning":false,"position":11,"left":409,"right":409},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":410,"text":" \tif (!HeapTupleIsValid(tuple))","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (!\u003cspan class=pl-en\u003eHeapTupleIsValid\u003c/span\u003e(\u003cspan class=pl-s1\u003etuple\u003c/span\u003e))","displayNoNewLineWarning":false,"position":12,"left":410,"right":410},{"stylingDirective":null,"type":"DELETION","blobLineNumber":411,"text":"-\t\telog(ERROR, \"cache lookup failed for replication origin with ID %u\",","html":"-\t\t\u003cspan class=\"pl-en\"\u003eelog\u003c/span\u003e(\u003cspan class=\"pl-c1\"\u003eERROR\u003c/span\u003e, \u003cspan class=\"pl-s\"\u003e\"cache lookup failed for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":13,"left":411,"right":410},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":411,"text":"+\t\telog(ERROR, \"cache lookup failed for replication origin with ID %d\",","html":"+\t\t\u003cspan class=\"pl-en\"\u003eelog\u003c/span\u003e(\u003cspan class=\"pl-c1\"\u003eERROR\u003c/span\u003e, \u003cspan class=\"pl-s\"\u003e\"cache lookup failed for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":14,"left":411,"right":411},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":412,"text":" \t\t\t roident);","html":" \t\t\t \u003cspan class=pl-s1\u003eroident\u003c/span\u003e);","displayNoNewLineWarning":false,"position":15,"left":412,"right":412},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":413,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":16,"left":413,"right":413},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":414,"text":" \tCatalogTupleDelete(rel, \u0026tuple-\u003et_self);","html":" \t\u003cspan class=pl-en\u003eCatalogTupleDelete\u003c/span\u003e(\u003cspan class=pl-s1\u003erel\u003c/span\u003e, \u003cspan class=pl-c1\u003e\u0026amp;\u003c/span\u003e\u003cspan class=pl-s1\u003etuple\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003et_self\u003c/span\u003e);","displayNoNewLineWarning":false,"position":17,"left":414,"right":414},{"stylingDirective":null,"type":"HUNK","blobLineNumber":484,"text":"@@ -485,7 +485,7 @@ replorigin_by_oid(RepOriginId roident, bool missing_ok, char **roname)","html":"@@ -485,7 +485,7 @@ replorigin_by_oid(RepOriginId roident, bool missing_ok, char **roname)","displayNoNewLineWarning":false,"position":18,"left":484,"right":484},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":485,"text":" \t\tif (!missing_ok)","html":" \t\t\u003cspan class=pl-k\u003eif\u003c/span\u003e (!\u003cspan class=pl-s1\u003emissing_ok\u003c/span\u003e)","displayNoNewLineWarning":false,"position":19,"left":485,"right":485},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":486,"text":" \t\t\tereport(ERROR,","html":" \t\t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":20,"left":486,"right":486},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":487,"text":" \t\t\t\t\t(errcode(ERRCODE_UNDEFINED_OBJECT),","html":" \t\t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_UNDEFINED_OBJECT\u003c/span\u003e),","displayNoNewLineWarning":false,"position":21,"left":487,"right":487},{"stylingDirective":null,"type":"DELETION","blobLineNumber":488,"text":"-\t\t\t\t\t errmsg(\"replication origin with ID %u does not exist\",","html":"-\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e does not exist\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":22,"left":488,"right":487},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":488,"text":"+\t\t\t\t\t errmsg(\"replication origin with ID %d does not exist\",","html":"+\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e does not exist\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":23,"left":488,"right":488},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":489,"text":" \t\t\t\t\t\t\troident)));","html":" \t\t\t\t\t\t\t\u003cspan class=pl-s1\u003eroident\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":24,"left":489,"right":489},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":490,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":25,"left":490,"right":490},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":491,"text":" \t\treturn false;","html":" \t\t\u003cspan class=pl-k\u003ereturn\u003c/span\u003e false;","displayNoNewLineWarning":false,"position":26,"left":491,"right":491},{"stylingDirective":null,"type":"HUNK","blobLineNumber":798,"text":"@@ -799,7 +799,7 @@ StartupReplicationOrigin(void)","html":"@@ -799,7 +799,7 @@ StartupReplicationOrigin(void)","displayNoNewLineWarning":false,"position":27,"left":798,"right":798},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":799,"text":" \t\tlast_state++;","html":" \t\t\u003cspan class=pl-s1\u003elast_state\u003c/span\u003e\u003cspan class=pl-c1\u003e++\u003c/span\u003e;","displayNoNewLineWarning":false,"position":28,"left":799,"right":799},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":800,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":29,"left":800,"right":800},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":801,"text":" \t\tereport(LOG,","html":" \t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eLOG\u003c/span\u003e,","displayNoNewLineWarning":false,"position":30,"left":801,"right":801},{"stylingDirective":null,"type":"DELETION","blobLineNumber":802,"text":"-\t\t\t\t(errmsg(\"recovered replication state of node %u to %X/%X\",","html":"-\t\t\t\t(\u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"recovered replication state of node %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e to %X/%X\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":31,"left":802,"right":801},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":802,"text":"+\t\t\t\t(errmsg(\"recovered replication state of node %d to %X/%X\",","html":"+\t\t\t\t(\u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"recovered replication state of node %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e to %X/%X\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":32,"left":802,"right":802},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":803,"text":" \t\t\t\t\t\tdisk_state.roident,","html":" \t\t\t\t\t\t\u003cspan class=pl-s1\u003edisk_state\u003c/span\u003e.\u003cspan class=pl-c1\u003eroident\u003c/span\u003e,","displayNoNewLineWarning":false,"position":33,"left":803,"right":803},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":804,"text":" \t\t\t\t\t\tLSN_FORMAT_ARGS(disk_state.remote_lsn))));","html":" \t\t\t\t\t\t\u003cspan class=pl-en\u003eLSN_FORMAT_ARGS\u003c/span\u003e(\u003cspan class=pl-s1\u003edisk_state\u003c/span\u003e.\u003cspan class=pl-c1\u003eremote_lsn\u003c/span\u003e))));","displayNoNewLineWarning":false,"position":34,"left":804,"right":804},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":805,"text":" \t}","html":" \t}","displayNoNewLineWarning":false,"position":35,"left":805,"right":805},{"stylingDirective":null,"type":"HUNK","blobLineNumber":936,"text":"@@ -937,7 +937,7 @@ replorigin_advance(RepOriginId node,","html":"@@ -937,7 +937,7 @@ replorigin_advance(RepOriginId node,","displayNoNewLineWarning":false,"position":36,"left":936,"right":936},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":937,"text":" \t\t{","html":" \t\t{","displayNoNewLineWarning":false,"position":37,"left":937,"right":937},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":938,"text":" \t\t\tereport(ERROR,","html":" \t\t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":38,"left":938,"right":938},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":939,"text":" \t\t\t\t\t(errcode(ERRCODE_OBJECT_IN_USE),","html":" \t\t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_OBJECT_IN_USE\u003c/span\u003e),","displayNoNewLineWarning":false,"position":39,"left":939,"right":939},{"stylingDirective":null,"type":"DELETION","blobLineNumber":940,"text":"-\t\t\t\t\t errmsg(\"replication origin with ID %u is already active for PID %d\",","html":"-\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e is already active for PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":40,"left":940,"right":939},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":940,"text":"+\t\t\t\t\t errmsg(\"replication origin with ID %d is already active for PID %d\",","html":"+\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e is already active for PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":41,"left":940,"right":940},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":941,"text":" \t\t\t\t\t\t\treplication_state-\u003eroident,","html":" \t\t\t\t\t\t\t\u003cspan class=pl-s1\u003ereplication_state\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eroident\u003c/span\u003e,","displayNoNewLineWarning":false,"position":42,"left":941,"right":941},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":942,"text":" \t\t\t\t\t\t\treplication_state-\u003eacquired_by)));","html":" \t\t\t\t\t\t\t\u003cspan class=pl-s1\u003ereplication_state\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eacquired_by\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":43,"left":942,"right":942},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":943,"text":" \t\t}","html":" \t\t}","displayNoNewLineWarning":false,"position":44,"left":943,"right":943},{"stylingDirective":null,"type":"HUNK","blobLineNumber":947,"text":"@@ -948,7 +948,7 @@ replorigin_advance(RepOriginId node,","html":"@@ -948,7 +948,7 @@ replorigin_advance(RepOriginId node,","displayNoNewLineWarning":false,"position":45,"left":947,"right":947},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":948,"text":" \tif (replication_state == NULL \u0026\u0026 free_state == NULL)","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003ereplication_state\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003eNULL\u003c/span\u003e \u003cspan class=pl-c1\u003e\u0026amp;\u0026amp;\u003c/span\u003e \u003cspan class=pl-s1\u003efree_state\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003eNULL\u003c/span\u003e)","displayNoNewLineWarning":false,"position":46,"left":948,"right":948},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":949,"text":" \t\tereport(ERROR,","html":" \t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":47,"left":949,"right":949},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":950,"text":" \t\t\t\t(errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED),","html":" \t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_CONFIGURATION_LIMIT_EXCEEDED\u003c/span\u003e),","displayNoNewLineWarning":false,"position":48,"left":950,"right":950},{"stylingDirective":null,"type":"DELETION","blobLineNumber":951,"text":"-\t\t\t\t errmsg(\"could not find free replication state slot for replication origin with ID %u\",","html":"-\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not find free replication state slot for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":49,"left":951,"right":950},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":951,"text":"+\t\t\t\t errmsg(\"could not find free replication state slot for replication origin with ID %d\",","html":"+\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not find free replication state slot for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":50,"left":951,"right":951},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":952,"text":" \t\t\t\t\t\tnode),","html":" \t\t\t\t\t\t\u003cspan class=pl-s1\u003enode\u003c/span\u003e),","displayNoNewLineWarning":false,"position":51,"left":952,"right":952},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":953,"text":" \t\t\t\t errhint(\"Increase max_replication_slots and try again.\")));","html":" \t\t\t\t \u003cspan class=pl-en\u003eerrhint\u003c/span\u003e(\u003cspan class=pl-s\u003e\u0026quot;Increase max_replication_slots and try again.\u0026quot;\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":52,"left":953,"right":953},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":954,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":53,"left":954,"right":954},{"stylingDirective":null,"type":"HUNK","blobLineNumber":1125,"text":"@@ -1126,7 +1126,7 @@ replorigin_session_setup(RepOriginId node)","html":"@@ -1126,7 +1126,7 @@ replorigin_session_setup(RepOriginId node)","displayNoNewLineWarning":false,"position":54,"left":1125,"right":1125},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1126,"text":" \t\t{","html":" \t\t{","displayNoNewLineWarning":false,"position":55,"left":1126,"right":1126},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1127,"text":" \t\t\tereport(ERROR,","html":" \t\t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":56,"left":1127,"right":1127},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1128,"text":" \t\t\t\t\t(errcode(ERRCODE_OBJECT_IN_USE),","html":" \t\t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_OBJECT_IN_USE\u003c/span\u003e),","displayNoNewLineWarning":false,"position":57,"left":1128,"right":1128},{"stylingDirective":null,"type":"DELETION","blobLineNumber":1129,"text":"-\t\t\t\t\t errmsg(\"replication origin with ID %u is already active for PID %d\",","html":"-\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e is already active for PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":58,"left":1129,"right":1128},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":1129,"text":"+\t\t\t\t\t errmsg(\"replication origin with ID %d is already active for PID %d\",","html":"+\t\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e is already active for PID %d\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":59,"left":1129,"right":1129},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1130,"text":" \t\t\t\t\t\t\tcurstate-\u003eroident, curstate-\u003eacquired_by)));","html":" \t\t\t\t\t\t\t\u003cspan class=pl-s1\u003ecurstate\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eroident\u003c/span\u003e, \u003cspan class=pl-s1\u003ecurstate\u003c/span\u003e\u003cspan class=pl-c1\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=pl-c1\u003eacquired_by\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":60,"left":1130,"right":1130},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1131,"text":" \t\t}","html":" \t\t}","displayNoNewLineWarning":false,"position":61,"left":1131,"right":1131},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1132,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":62,"left":1132,"right":1132},{"stylingDirective":null,"type":"HUNK","blobLineNumber":1137,"text":"@@ -1138,7 +1138,7 @@ replorigin_session_setup(RepOriginId node)","html":"@@ -1138,7 +1138,7 @@ replorigin_session_setup(RepOriginId node)","displayNoNewLineWarning":false,"position":63,"left":1137,"right":1137},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1138,"text":" \tif (session_replication_state == NULL \u0026\u0026 free_slot == -1)","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003esession_replication_state\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003eNULL\u003c/span\u003e \u003cspan class=pl-c1\u003e\u0026amp;\u0026amp;\u003c/span\u003e \u003cspan class=pl-s1\u003efree_slot\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003e-1\u003c/span\u003e)","displayNoNewLineWarning":false,"position":64,"left":1138,"right":1138},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1139,"text":" \t\tereport(ERROR,","html":" \t\t\u003cspan class=pl-en\u003eereport\u003c/span\u003e(\u003cspan class=pl-c1\u003eERROR\u003c/span\u003e,","displayNoNewLineWarning":false,"position":65,"left":1139,"right":1139},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1140,"text":" \t\t\t\t(errcode(ERRCODE_CONFIGURATION_LIMIT_EXCEEDED),","html":" \t\t\t\t(\u003cspan class=pl-en\u003eerrcode\u003c/span\u003e(\u003cspan class=pl-c1\u003eERRCODE_CONFIGURATION_LIMIT_EXCEEDED\u003c/span\u003e),","displayNoNewLineWarning":false,"position":66,"left":1140,"right":1140},{"stylingDirective":null,"type":"DELETION","blobLineNumber":1141,"text":"-\t\t\t\t errmsg(\"could not find free replication state slot for replication origin with ID %u\",","html":"-\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not find free replication state slot for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003eu\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":67,"left":1141,"right":1140},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":1141,"text":"+\t\t\t\t errmsg(\"could not find free replication state slot for replication origin with ID %d\",","html":"+\t\t\t\t \u003cspan class=\"pl-en\"\u003eerrmsg\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\"could not find free replication state slot for replication origin with ID %\u003cspan class=\"x x-first x-last\"\u003ed\u003c/span\u003e\"\u003c/span\u003e,","displayNoNewLineWarning":false,"position":68,"left":1141,"right":1141},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1142,"text":" \t\t\t\t\t\tnode),","html":" \t\t\t\t\t\t\u003cspan class=pl-s1\u003enode\u003c/span\u003e),","displayNoNewLineWarning":false,"position":69,"left":1142,"right":1142},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1143,"text":" \t\t\t\t errhint(\"Increase max_replication_slots and try again.\")));","html":" \t\t\t\t \u003cspan class=pl-en\u003eerrhint\u003c/span\u003e(\u003cspan class=pl-s\u003e\u0026quot;Increase max_replication_slots and try again.\u0026quot;\u003c/span\u003e)));","displayNoNewLineWarning":false,"position":70,"left":1143,"right":1143},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":1144,"text":" \telse if (session_replication_state == NULL)","html":" \t\u003cspan class=pl-k\u003eelse\u003c/span\u003e \u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003esession_replication_state\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-c1\u003eNULL\u003c/span\u003e)","displayNoNewLineWarning":false,"position":71,"left":1144,"right":1144}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":1565,"linesChanged":16,"newTreeEntry":{"lineCount":1565,"path":"src/backend/replication/logical/origin.c","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/backend/replication/logical/origin.c","mode":100644},"linesAdded":8,"linesDeleted":8,"path":"src/backend/replication/logical/origin.c","pathDigest":"940a4f0401426589802521c5ccd88f007ffc89e76be18ae5199282e5f2e5955f","status":"MODIFIED","truncatedReason":null,"oldOid":"1b9050da66aba821fec18376bee30d17e91e7027","newOid":"ba8321349bc02423aa4d49ebb5d579ec313cf930","copilotChatReference":null,"deletedSha":"1b9050da66aba821fec18376bee30d17e91e7027","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/ba8321349bc02423aa4d49ebb5d579ec313cf930","fileTreeExpanded":true,"headerInfo":{"additions":8,"deletions":8,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":3077,"lineShownCount":72},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"6NRiXbH9ksi4b6qxHRipepVmCt1UlEvaWgzG7bAQe9kKmGmS8jYugPE75RlmWXuHJ5k0NYJsvjZpuELwrTPWZQ"},"/users/diffview?diff=unified":{"post":"7b5fYm5YVRpnHNgjsACjk6xsD4wDAkBCBsWf8Jin5QQP8lStLZPpUi5Il4vLQXFuHpMxZNX6ta41cRvthYRIuA"},"/notifications/thread":{"post":"umNTk3bnVGlfvjDut4d-h1Bpt7QqgRHbXuGF9qAK2hchebb6iFN2EI6kGarKQQAQ7lbS-S22nD5f8awEEvIjQA"}}},"title":"Switch format specifier for replication origins to %d · postgres/postgres@ba83213","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
0 commit comments