8000 Remove unnecessary grammar symbols · postgres/postgres@a6964bc · GitHub
[go: up one dir, main page]
Skip to content
{"payload":{"commit":{"oid":"a6964bc1bb0793e20636ccb573cd2a5ad3ef7667","url":"/postgres/postgres/commit/a6964bc1bb0793e20636ccb573cd2a5ad3ef7667","authoredDate":"2020-12-04T11:09:29.000+01:00","committedDate":"2020-12-04T11:16:26.000+01:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eRemove unnecessary grammar symbols\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"Instead of publication_name_list, we can use name_list. We already\nrefer to publications everywhere else by the 'name' or 'name_list'\nsymbols, so this only improves consistency.\n\nReviewed-by: \u003ca href=\"https://www.postgresql.org/message-id/flat/3e3ccddb-41bd-ecd8-29fe-195e34d9886f%40enterprisedb.com\" rel=\"nofollow\"\u003ehttps://www.postgresql.org/message-id/flat/3e3ccddb-41bd-ecd8-29fe-195e34d9886f%40enterprisedb.com\u003c/a\u003e\nDiscussion: Tom Lane \u0026lt;tgl@sss.pgh.pa.us\u0026gt;","authors":[{"login":"petere","displayName":"Peter Eisentraut","avatarUrl":"https://avatars.githubusercontent.com/u/105543?v=4","path":"/petere","isGitHub":false}],"committerAttribution":false,"committer":{"login":"petere","displayName":"Peter Eisentraut","avatarUrl":"https://avatars.githubusercontent.com/u/105543?v=4","path":"/petere","isGitHub":false},"parents":["8ae4ef4fb0e0331f02c4615182600546c8e5c4d4"],"globalRelayId":"MDY6Q29tbWl0OTI3NDQyOmE2OTY0YmMxYmIwNzkzZTIwNjM2Y2NiNTczY2QyYTVhZDNlZjc2Njc=","sha1":"8ae4ef4fb0e0331f02c4615182600546c8e5c4d4","sha2":"a6964bc1bb0793e20636ccb573cd2a5ad3ef7667"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":413,"text":"@@ -414,15 +414,13 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);","html":"@@ -414,15 +414,13 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);","displayNoNewLineWarning":false,"position":0,"left":413,"right":413},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":414,"text":" \t\t\t\trelation_expr_list dostmt_opt_list","html":" \t\t\t\t\u003cspan class=\"pl-c1\"\u003erelation_expr_list\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003edostmt_opt_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":1,"left":414,"right":414},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":415,"text":" \t\t\t\ttransform_element_list transform_type_list","html":" \t\t\t\t\u003cspan class=\"pl-c1\"\u003etransform_element_list\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003etransform_type_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":2,"left":415,"right":415},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":416,"text":" \t\t\t\tTriggerTransitions TriggerReferencing","html":" \t\t\t\t\u003cspan class=\"pl-c1\"\u003eTriggerTransitions\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003eTriggerReferencing\u003c/span\u003e","displayNoNewLineWarning":false,"position":3,"left":416,"right":416},{"stylingDirective":null,"type":"DELETION","blobLineNumber":417,"text":"-\t\t\t\tpublication_name_list","html":"-\t\t\t\t\u003cspan class=\"pl-c1\"\u003epublication_name_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":4,"left":417,"right":416},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":417,"text":" \t\t\t\tvacuum_relation_list opt_vacuum_relation_list","html":" \t\t\t\t\u003cspan class=\"pl-c1\"\u003evacuum_relation_list\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003eopt_vacuum_relation_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":5,"left":418,"right":417},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":418,"text":" \t\t\t\tdrop_option_list","html":" \t\t\t\t\u003cspan class=\"pl-c1\"\u003edrop_option_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":6,"left":419,"right":418},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":419,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":7,"left":420,"right":419},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":420,"text":" %type \u003clist\u003e\tgroup_by_list","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;list\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003egroup_by_list\u003c/span\u003e","displayNoNewLineWarning":false,"position":8,"left":421,"right":420},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":421,"text":" %type \u003cnode\u003e\tgroup_by_item empty_grouping_set rollup_clause cube_clause","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;node\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003egroup_by_item\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003eempty_grouping_set\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003erollup_clause\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003ecube_clause\u003c/span\u003e","displayNoNewLineWarning":false,"position":9,"left":422,"right":421},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":422,"text":" %type \u003cnode\u003e\tgrouping_sets_clause","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;node\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003egrouping_sets_clause\u003c/span\u003e","displayNoNewLineWarning":false,"position":10,"left":423,"right":422},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":423,"text":" %type \u003cnode\u003e\topt_publication_for_tables publication_for_tables","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;node\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003eopt_publication_for_tables\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003epublication_for_tables\u003c/span\u003e","displayNoNewLineWarning":false,"position":11,"left":424,"right":423},{"stylingDirective":null,"type":"DELETION","blobLineNumber":425,"text":"-%type \u003cvalue\u003e\tpublication_name_item","html":"-\u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;value\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003epublication_name_item\u003c/span\u003e","displayNoNewLineWarning":false,"position":12,"left":425,"right":423},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":424,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":13,"left":426,"right":424},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":425,"text":" %type \u003clist\u003e\topt_fdw_options fdw_options","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;list\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003eopt_fdw_options\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003efdw_options\u003c/span\u003e","displayNoNewLineWarning":false,"position":14,"left":427,"right":425},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":426,"text":" %type \u003cdefelt\u003e\tfdw_option","html":" \u003cspan class=\"pl-k\"\u003e%type\u003c/span\u003e \u003cspan class=\"pl-k\"\u003e\u0026lt;defelt\u0026gt;\u003c/span\u003e\t\u003cspan class=\"pl-c1\"\u003efdw_option\u003c/span\u003e","displayNoNewLineWarning":false,"position":15,"left":428,"right":426},{"stylingDirective":null,"type":"HUNK","blobLineNumber":9509,"text":"@@ -9512,7 +9510,7 @@ AlterPublicationStmt:","html":"@@ -9512,7 +9510,7 @@ AlterPublicationStmt:","displayNoNewLineWarning":false,"position":16,"left":9511,"right":9509},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9510,"text":" *****************************************************************************/","html":" \u003cspan class=\"pl-c\"\u003e ****************************************************************************\u003cspan class=\"pl-c\"\u003e*/\u003c/span\u003e\u003c/span\u003e","displayNoNewLineWarning":false,"position":17,"left":9512,"right":9510},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9511,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":18,"left":9513,"right":9511},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9512,"text":" CreateSubscriptionStmt:","html":" \u003cspan class=\"pl-en\"\u003eCreateSubscriptionStmt\u003c/span\u003e:","displayNoNewLineWarning":false,"position":19,"left":9514,"right":9512},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9515,"text":"-\t\t\tCREATE SUBSCRIPTION name CONNECTION Sconst PUBLICATION publication_name_list opt_definition","html":"-\t\t\t\u003cspan class=\"pl-en\"\u003eCREATE\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSUBSCRIPTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ename\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eCONNECTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSconst\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ePUBLICATION\u003c/span\u003e \u003cspan class=\"pl-en x x-first x-last\"\u003epublication_name_list\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eopt_definition\u003c/span\u003e","displayNoNewLineWarning":false,"position":20,"left":9515,"right":9512},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":9513,"text":"+\t\t\tCREATE SUBSCRIPTION name CONNECTION Sconst PUBLICATION name_list opt_definition","html":"+\t\t\t\u003cspan class=\"pl-en\"\u003eCREATE\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSUBSCRIPTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ename\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eCONNECTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSconst\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ePUBLICATION\u003c/span\u003e \u003cspan class=\"pl-en x x-first x-last\"\u003ename_list\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eopt_definition\u003c/span\u003e","displayNoNewLineWarning":false,"position":21,"left":9515,"right":9513},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9514,"text":" \t\t\t\t{","html":" \t\t\t\t{","displayNoNewLineWarning":false,"position":22,"left":9516,"right":9514},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9515,"text":" \t\t\t\t\tCreateSubscriptionStmt *n =","html":" \t\t\t\t\tCreateSubscriptionStmt *n =","displayNoNewLineWarning":false,"position":23,"left":9517,"right":9515},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9516,"text":" \t\t\t\t\t\tmakeNode(CreateSubscriptionStmt);","html":" \t\t\t\t\t\t\u003cspan class=\"pl-en\"\u003emakeNode\u003c/span\u003e(CreateSubscriptionStmt);","displayNoNewLineWarning":false,"position":24,"left":9518,"right":9516},{"stylingDirective":null,"type":"HUNK","blobLineNumber":9521,"text":"@@ -9524,20 +9522,6 @@ CreateSubscriptionStmt:","html":"@@ -9524,20 +9522,6 @@ CreateSubscriptionStmt:","displayNoNewLineWarning":false,"position":25,"left":9523,"right":9521},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9522,"text":" \t\t\t\t}","html":" \t\t\t\t}","displayNoNewLineWarning":false,"position":26,"left":9524,"right":9522},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9523,"text":" \t\t;","html":" \t\t;","displayNoNewLineWarning":false,"position":27,"left":9525,"right":9523},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9524,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":28,"left":9526,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9527,"text":"-publication_name_list:","html":"-\u003cspan class=\"pl-en\"\u003epublication_name_list\u003c/span\u003e:","displayNoNewLineWarning":false,"position":29,"left":9527,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9528,"text":"-\t\t\tpublication_name_item","html":"-\t\t\t\u003cspan class=\"pl-en\"\u003epublication_name_item\u003c/span\u003e","displayNoNewLineWarning":false,"position":30,"left":9528,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9529,"text":"-\t\t\t\t{","html":"-\t\t\t\t{","displayNoNewLineWarning":false,"position":31,"left":9529,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9530,"text":"-\t\t\t\t\t$$ = list_make1($1);","html":"-\t\t\t\t\t\u003cspan class=\"pl-c1\"\u003e$$\u003c/span\u003e = list_make1(\u003cspan class=\"pl-c1\"\u003e$1\u003c/span\u003e);","displayNoNewLineWarning":false,"position":32,"left":9530,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9531,"text":"-\t\t\t\t}","html":"-\t\t\t\t}","displayNoNewLineWarning":false,"position":33,"left":9531,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9532,"text":"-\t\t\t| publication_name_list ',' publication_name_item","html":"-\t\t\t\u003cspan class=\"pl-k\"\u003e|\u003c/span\u003e \u003cspan class=\"pl-en\"\u003epublication_name_list\u003c/span\u003e \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e,\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e \u003cspan class=\"pl-en\"\u003epublication_name_item\u003c/span\u003e","displayNoNewLineWarning":false,"position":34,"left":9532,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9533,"text":"-\t\t\t\t{","html":"-\t\t\t\t{","displayNoNewLineWarning":false,"position":35,"left":9533,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9534,"text":"-\t\t\t\t\t$$ = lappend($1, $3);","html":"-\t\t\t\t\t\u003cspan class=\"pl-c1\"\u003e$$\u003c/span\u003e = lappend(\u003cspan class=\"pl-c1\"\u003e$1\u003c/span\u003e, \u003cspan class=\"pl-c1\"\u003e$3\u003c/span\u003e);","displayNoNewLineWarning":false,"position":36,"left":9534,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9535,"text":"-\t\t\t\t}","html":"-\t\t\t\t}","displayNoNewLineWarning":false,"position":37,"left":9535,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9536,"text":"-\t\t;","html":"-\t\t;","displayNoNewLineWarning":false,"position":38,"left":9536,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9537,"text":"-","html":"-","displayNoNewLineWarning":false,"position":39,"left":9537,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9538,"text":"-publication_name_item:","html":"-\u003cspan class=\"pl-en\"\u003epublication_name_item\u003c/span\u003e:","displayNoNewLineWarning":false,"position":40,"left":9538,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9539,"text":"-\t\t\tColLabel\t\t\t{ $$ = makeString($1); };","html":"-\t\t\t\u003cspan class=\"pl-en\"\u003eColLabel\u003c/span\u003e\t\t\t{ \u003cspan class=\"pl-c1\"\u003e$$\u003c/span\u003e = makeString(\u003cspan class=\"pl-c1\"\u003e$1\u003c/span\u003e); };","displayNoNewLineWarning":false,"position":41,"left":9539,"right":9524},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9540,"text":"-","html":"-","displayNoNewLineWarning":false,"position":42,"left":9540,"right":9524},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9525,"text":" /*****************************************************************************","html":" \u003cspan class=\"pl-c\"\u003e\u003cspan class=\"pl-c\"\u003e/*\u003c/span\u003e****************************************************************************\u003c/span\u003e","displayNoNewLineWarning":false,"position":43,"left":9541,"right":9525},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9526,"text":" *","html":" \u003cspan class=\"pl-c\"\u003e *\u003c/span\u003e","displayNoNewLineWarning":false,"position":44,"left":9542,"right":9526},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9527,"text":" * ALTER SUBSCRIPTION name ...","html":" \u003cspan class=\"pl-c\"\u003e * ALTER SUBSCRIPTION name ...\u003c/span\u003e","displayNoNewLineWarning":false,"position":45,"left":9543,"right":9527},{"stylingDirective":null,"type":"HUNK","blobLineNumber":9555,"text":"@@ -9572,7 +9556,7 @@ AlterSubscriptionStmt:","html":"@@ -9572,7 +9556,7 @@ AlterSubscriptionStmt:","displayNoNewLineWarning":false,"position":46,"left":9571,"right":9555},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9556,"text":" \t\t\t\t\tn-\u003eoptions = $6;","html":" \t\t\t\t\tn-\u0026gt;options = \u003cspan class=\"pl-c1\"\u003e$6\u003c/span\u003e;","displayNoNewLineWarning":false,"position":47,"left":9572,"right":9556},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9557,"text":" \t\t\t\t\t$$ = (Node *)n;","html":" \t\t\t\t\t\u003cspan class=\"pl-c1\"\u003e$$\u003c/span\u003e = (Node *)n;","displayNoNewLineWarning":false,"position":48,"left":9573,"right":9557},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9558,"text":" \t\t\t\t}","html":" \t\t\t\t}","displayNoNewLineWarning":false,"position":49,"left":9574,"right":9558},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9575,"text":"-\t\t\t| ALTER SUBSCRIPTION name SET PUBLICATION publication_name_list opt_definition","html":"-\t\t\t\u003cspan class=\"pl-k\"\u003e|\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eALTER\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSUBSCRIPTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ename\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSET\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ePUBLICATION\u003c/span\u003e \u003cspan class=\"pl-en x x-first x-last\"\u003epublication_name_list\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eopt_definition\u003c/span\u003e","displayNoNewLineWarning":false,"position":50,"left":9575,"right":9558},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":9559,"text":"+\t\t\t| ALTER SUBSCRIPTION name SET PUBLICATION name_list opt_definition","html":"+\t\t\t\u003cspan class=\"pl-k\"\u003e|\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eALTER\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSUBSCRIPTION\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ename\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eSET\u003c/span\u003e \u003cspan class=\"pl-en\"\u003ePUBLICATION\u003c/span\u003e \u003cspan class=\"pl-en x x-first x-last\"\u003ename_list\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eopt_definition\u003c/span\u003e","displayNoNewLineWarning":false,"position":51,"left":9575,"right":9559},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9560,"text":" \t\t\t\t{","html":" \t\t\t\t{","displayNoNewLineWarning":false,"position":52,"left":9576,"right":9560},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9561,"text":" \t\t\t\t\tAlterSubscriptionStmt *n =","html":" \t\t\t\t\tAlterSubscriptionStmt *n =","displayNoNewLineWarning":false,"position":53,"left":9577,"right":9561},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":9562,"text":" \t\t\t\t\t\tmakeNode(AlterSubscriptionStmt);","html":" \t\t\t\t\t\t\u003cspan class=\"pl-en\"\u003emakeNode\u003c/span\u003e(AlterSubscriptionStmt);","displayNoNewLineWarning":false,"position":54,"left":9578,"right":9562}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":16875,"linesChanged":20,"newTreeEntry":{"lineCount":16875,"path":"src/backend/parser/gram.y","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/backend/parser/gram.y","mode":100644},"linesAdded":2,"linesDeleted":18,"path":"src/backend/parser/gram.y","pathDigest":"46b3d04d01695e2f03dd655e14087ef74a793b725ef5c8c7a8c365c51667d182","status":"MODIFIED","truncatedReason":null,"oldOid":"8ae4ef4fb0e0331f02c4615182600546c8e5c4d4","newOid":"a6964bc1bb0793e20636ccb573cd2a5ad3ef7667","copilotChatReference":null,"deletedSha":"8ae4ef4fb0e0331f02c4615182600546c8e5c4d4","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/a6964bc1bb0793e20636ccb573cd2a5ad3ef7667","fileTreeExpanded":true,"headerInfo":{"additions":2,"deletions":18,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":1826,"lineShownCount":55},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"Jen68qBkeMblsnep9nuZOXBshUa7aHhGCYT06IjWISdKgg67mcVhqakwu3v_-8MY1jWEi5QPQfXUHRjyWF-9sQ"},"/users/diffview?diff=unified":{"post":"bmGqpgmn6425D9GJGDJHIuM66DXdKs3sq2r8H_SRNRABCl7vMAby4vWNHVsRsh0DRWPp-PJN9F928xAFJBiphg"},"/notifications/thread":{"post":"wG_475Lzrarwf77FA9DakEAqx6ZvJcvqbihRs5j1T_oqTDRF-TrJ-B0VGqBvMchaqU_jJZDDWKANL4fx9XVf8w"}}},"title":"Remove unnecessary grammar symbols · postgres/postgres@a6964bc","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}

Commit a6964bc

Browse files
peterepetere
committed
Remove unnecessary grammar symbols
Instead of publication_name_list, we can use name_list. We already refer to publications everywhere else by the 'name' or 'name_list' symbols, so this only improves consistency. Reviewed-by: https://www.postgresql.org/message-id/flat/3e3ccddb-41bd-ecd8-29fe-195e34d9886f%40enterprisedb.com Discussion: Tom Lane <tgl@sss.pgh.pa.us>
1 parent 8ae4ef4 commit a6964bc

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

‎src/backend/parser/gram.y

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -414,15 +414,13 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
414414
relation_expr_list dostmt_opt_list
415415
transform_element_list transform_type_list
416416
TriggerTransitions TriggerReferencing
417-
publication_name_list
418417
vacuum_relation_list opt_vacuum_relation_list
419418
drop_option_list
420419

421420
%type <list> group_by_list
422421
%type <node> group_by_item empty_grouping_set rollup_clause cube_clause
423422
%type <node> grouping_sets_clause
424423
%type <node> opt_publication_for_tables publication_for_tables
425-
%type <value> publication_name_item
426424

427425
%type <list> opt_fdw_options fdw_options
428426
%type <defelt> fdw_option
@@ -9512,7 +9510,7 @@ AlterPublicationStmt:
95129510
*****************************************************************************/
95139511

95149512
CreateSubscriptionStmt:
9515-
CREATE SUBSCRIPTION name CONNECTION Sconst PUBLICATION publication_name_list opt_definition
9513+
CREATE SUBSCRIPTION name CONNECTION Sconst PUBLICATION name_list opt_definition
95169514
{
95179515
CreateSubscriptionStmt *n =
95189516
makeNode(CreateSubscriptionStmt);
@@ -9524,20 +9522,6 @@ CreateSubscriptionStmt:
95249522
}
95259523
;
95269524

9527-
publication_name_list:
9528-
publication_name_item
9529-
{
9530-
$$ = list_make1($1);
9531-
}
9532-
| publication_name_list ',' publication_name_item
9533-
{
9534-
$$ = lappend($1, $3);
9535-
}
9536-
;
9537-
9538-
publication_name_item:
9539-
ColLabel { $$ = makeString($1); };
9540-
95419525
/*****************************************************************************
95429526
*
95439527
* ALTER SUBSCRIPTION name ...
@@ -9572,7 +9556,7 @@ AlterSubscriptionStmt:
95729556
n->options = $6;
95739557
$$ = (Node *)n;
95749558
}
9575-
| ALTER SUBSCRIPTION name SET PUBLICATION publication_name_list opt_definition
9559+
| ALTER SUBSCRIPTION name SET PUBLICATION name_list opt_definition
95769560
{
95779561
AlterSubscriptionStmt *n =
95789562
makeNode(AlterSubscriptionStmt);

0 commit comments

Comments
 (0)
0