<
8000
script type="application/json" data-target="react-app.embeddedData">{"payload":{"commit":{"oid":"a1105c3dd44c1fb76eb62a708f0421f21b9dde9b","url":"/postgres/postgres/commit/a1105c3dd44c1fb76eb62a708f0421f21b9dde9b","authoredDate":"2015-03-23T14:51:59.000+01:00","committedDate":"2015-03-23T15:53:40.000+01:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eFix copy \u0026amp; paste error in \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/postgres/postgres/commit/4f1b890b1377744688e43218f975d3c8b2ae39f8/hovercard\" href=\"https://github.com/postgres/postgres/commit/4f1b890b1377744688e43218f975d3c8b2ae39f8\"\u003e\u003ctt\u003e4f1b890\u003c/tt\u003e\u003c/a\u003e.\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"Due to the bug delayed standbys would not delay when applying prepared\ntransactions.\n\nDiscussion: CAB7nPqT6BO1cCn+sAyDByBxA4EKZNAiPi2mFJ=ANeZmnmewRyg@mail.gmail.com\n\nMichael Paquier via Coverity.","authors":[{"login":"anarazel","displayName":"Andres Freund","avatarUrl":"https://avatars.githubusercontent.com/u/1598211?v=4","path":"/anarazel","isGitHub":false}],"committerAttribution":false,"committer":{"login":"anarazel","displayName":"Andres Freund","avatarUrl":"https://avatars.githubusercontent.com/u/1598211?v=4","path":"/anarazel","isGitHub":false},"parents":["372b97097e8c9a67326e99a07da30ab44f6f822a"],"globalRelayId":"MDY6Q29tbWl0OTI3NDQyOmExMTA1YzNkZDQ0YzFmYjc2ZWI2MmE3MDhmMDQyMWYyMWI5ZGRlOWI=","sha1":"372b97097e8c9a67326e99a07da30ab44f6f822a","sha2":"a1105c3dd44c1fb76eb62a708f0421f21b9dde9b"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":5533,"text":"@@ -5534,7 +5534,7 @@ recoveryApplyDelay(XLogReaderState *record)","html":"@@ -5534,7 +5534,7 @@ recoveryApplyDelay(XLogReaderState *record)","displayNoNewLineWarning":false,"position":0,"left":5533,"right":5533},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5534,"text":" \tif (XLogRecGetRmid(record) != RM_XACT_ID)","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-en\u003eXLogRecGetRmid\u003c/span\u003e(\u003cspan class=pl-s1\u003erecord\u003c/span\u003e) \u003cspan class=pl-c1\u003e!=\u003c/span\u003e \u003cspan class=pl-c1\u003eRM_XACT_ID\u003c/span\u003e)","displayNoNewLineWarning":false,"position":1,"left":5534,"right":5534},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5535,"text":" \t\treturn false;","html":" \t\t\u003cspan class=pl-k\u003ereturn\u003c/span\u003e false;","displayNoNewLineWarning":false,"position":2,"left":5535,"right":5535},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5536,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":3,"left":5536,"right":5536},{"stylingDirective":null,"type":"DELETION","blobLineNumber":5537,"text":"-\txact_info = XLogRecGetInfo(record) \u0026 XLOG_XACT_COMMIT;","html":"-\t\u003cspan class=\"pl-s1\"\u003exact_info\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003e=\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eXLogRecGetInfo\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003erecord\u003c/span\u003e) \u003cspan class=\"pl-c1\"\u003e\u0026amp;\u003c/span\u003e \u003cspan class=\"pl-c1 x x-first x-last\"\u003eXLOG_XACT_COMMIT\u003c/span\u003e;","displayNoNewLineWarning":false,"position":4,"left":5537,"right":5536},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":5537,"text":"+\txact_info = XLogRecGetInfo(record) \u0026 XLOG_XACT_OPMASK;","html":"+\t\u003cspan class=\"pl-s1\"\u003exact_info\u003c/span\u003e \u003cspan class=\"pl-c1\"\u003e=\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eXLogRecGetInfo\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003erecord\u003c/span\u003e) \u003cspan class=\"pl-c1\"\u003e\u0026amp;\u003c/span\u003e \u003cspan class=\"pl-c1 x x-first x-last\"\u003eXLOG_XACT_OPMASK\u003c/span\u003e;","displayNoNewLineWarning":false,"position":5,"left":5537,"right":5537},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5538,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":6,"left":5538,"right":5538},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5539,"text":" \tif (xact_info != XLOG_XACT_COMMIT \u0026\u0026","html":" \t\u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003exact_info\u003c/span\u003e \u003cspan class=pl-c1\u003e!=\u003c/span\u003e \u003cspan class=pl-c1\u003eXLOG_XACT_COMMIT\u003c/span\u003e \u003cspan class=pl-c1\u003e\u0026amp;\u0026amp;\u003c/span\u003e","displayNoNewLineWarning":false,"position":7,"left":5539,"right":5539},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5540,"text":" \t\txact_info != XLOG_XACT_COMMIT_PREPARED)","html":" \t\t\u003cspan class=pl-s1\u003exact_info\u003c/span\u003e \u003cspan class=pl-c1\u003e!=\u003c/span\u003e \u003cspan class=pl-c1\u003eXLOG_XACT_COMMIT_PREPARED\u003c/span\u003e)","displayNoNewLineWarning":false,"position":8,"left":5540,"right":5540}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":11001,"linesChanged":2,"newTreeEntry":{"lineCount":11001,"path":"src/backend/access/transam/xlog.c","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/backend/access/transam/xlog.c","mode":100644},"linesAdded":1,"linesDeleted":1,"path":"src/backend/access/transam/xlog.c","pathDigest":"c1cb3ab2a19606390c1a7ed00ffe5a45531702ca5faf999d401c548f8951c65b","status":"MODIFIED","truncatedReason":null,"oldOid":"372b97097e8c9a67326e99a07da30ab44f6f822a","newOid":"a1105c3dd44c1fb76eb62a708f0421f21b9dde9b","copilotChatReference":null,"deletedSha":"372b97097e8c9a67326e99a07da30ab44f6f822a","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/a1105c3dd44c1fb76eb62a708f0421f21b9dde9b","fileTreeExpanded":true,"headerInfo":{"additions":1,"deletions":1,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":326,"lineShownCount":9},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"PrbCeNocezG8ZeALLxYjpsNoTH0Srbvf6Rpnn0Ovq0u5pSWJ2ZAbuGFhXGlUBSeuwGfracYcklKkk0QNiCpUeg"},"/users/diffview?diff=unified":{"post":"S8N129kaD0TI2T_bhJ2gLK_qWxW6sQN12XvM2JwehL3M0JIq2pZvzRXdg7n_jqQkrOX8AW4AKviU8u9KV5t7jA"},"/notifications/thread":{"post":"V-3I0lc43nWVdT59JnNBZB51nHJxdbDIbyaBRKmAk3IGlIalxXtqhVjv57Uqq82Sn0Lk9ZJMXM4y46Ut8_dzHQ"}}},"title":"Fix copy \u0026 paste error in 4f1b890b137. · postgres/postgres@a1105c3","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
File tree Expand file tree Collapse file tree 1 file changed +1
-1
lines changed
src/backend/access/transam Expand file tree Collapse file tree 1 file changed +1
-1
lines changed Original file line number Diff line number Diff line change @@ -5534,7 +5534,7 @@ recoveryApplyDelay(XLogReaderState *record)
5534
5534
if (XLogRecGetRmid (record ) != RM_XACT_ID )
5535
5535
return false;
5536
5536
5537
- xact_info = XLogRecGetInfo (record ) & XLOG_XACT_COMMIT ;
5537
+ xact_info = XLogRecGetInfo (record ) & XLOG_XACT_OPMASK ;
5538
5538
5539
5539
if (xact_info != XLOG_XACT_COMMIT &&
5540
5540
xact_info != XLOG_XACT_COMMIT_PREPARED )
You can’t perform that action at this time.
0 commit comments