Remove debug messages from tuplesort_sort_memtuples()

j-naylor · j-naylor · commit 6e647ef0e750 · 2022-05-23T13:11:43.000+07:00
These were of value only during development. Reported by Justin Pryzby Discussion: https://www.postgresql.org/message-id/20220519201254.GU19626%40telsasoft.com
diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
@@ -3664,7 +3664,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)
 		{
 			if (state->sortKeys[0].comparator == ssup_datum_unsigned_cmp)
 			{
-				elog(DEBUG1, "qsort_tuple_unsigned");
 				qsort_tuple_unsigned(state->memtuples,
 									 state->memtupcount,
 									 state);
@@ -3673,7 +3672,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)
 #if SIZEOF_DATUM >= 8
 			else if (state->sortKeys[0].comparator == ssup_datum_signed_cmp)
 			{
-				elog(DEBUG1, "qsort_tuple_signed");
 				qsort_tuple_signed(state->memtuples,
 								   state->memtupcount,
 								   state);
@@ -3682,7 +3680,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)
 #endif
 			else if (state->sortKeys[0].comparator == ssup_datum_int32_cmp)
 			{
-				elog(DEBUG1, "qsort_tuple_int32");
 				qsort_tuple_int32(state->memtuples,
 								  state->memtupcount,
 								  state);
@@ -3693,13 +3690,11 @@ tuplesort_sort_memtuples(Tuplesortstate *state)
 		/* Can we use the single-key sort function? */
 		if (state->onlyKey != NULL)
 		{
-			elog(DEBUG1, "qsort_ssup");
 			qsort_ssup(state->memtuples, state->memtupcount,
 					   state->onlyKey);
 		}
 		else
 		{
-			elog(DEBUG1, "qsort_tuple");
 			qsort_tuple(state->memtuples,
 						state->memtupcount,
 						state->comparetup,

Original file line number	Diff line number	Diff line change
`@@ -3664,7 +3664,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)`
`3664`	`3664`	`{`
`3665`	`3665`	`if (state->sortKeys[0].comparator == ssup_datum_unsigned_cmp)`
`3666`	`3666`	`{`
`3667`		`- elog(DEBUG1, "qsort_tuple_unsigned");`
`3668`	`3667`	`qsort_tuple_unsigned(state->memtuples,`
`3669`	`3668`	`state->memtupcount,`
`3670`	`3669`	`state);`
`@@ -3673,7 +3672,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)`
`3673`	`3672`	`#if SIZEOF_DATUM >= 8`
`3674`	`3673`	`else if (state->sortKeys[0].comparator == ssup_datum_signed_cmp)`
`3675`	`3674`	`{`
`3676`		`- elog(DEBUG1, "qsort_tuple_signed");`
`3677`	`3675`	`qsort_tuple_signed(state->memtuples,`
`3678`	`3676`	`state->memtupcount,`
`3679`	`3677`	`state);`
`@@ -3682,7 +3680,6 @@ tuplesort_sort_memtuples(Tuplesortstate *state)`
`3682`	`3680`	`#endif`
`3683`	`3681`	`else if (state->sortKeys[0].comparator == ssup_datum_int32_cmp)`
`3684`	`3682`	`{`
`3685`		`- elog(DEBUG1, "qsort_tuple_int32");`
`3686`	`3683`	`qsort_tuple_int32(state->memtuples,`
`3687`	`3684`	`state->memtupcount,`
`3688`	`3685`	`state);`
`@@ -3693,13 +3690,11 @@ tuplesort_sort_memtuples(Tuplesortstate *state)`
`3693`	`3690`	`/* Can we use the single-key sort function? */`
`3694`	`3691`	`if (state->onlyKey != NULL)`
`3695`	`3692`	`{`
`3696`		`- elog(DEBUG1, "qsort_ssup");`
`3697`	`3693`	`qsort_ssup(state->memtuples, state->memtupcount,`
`3698`	`3694`	`state->onlyKey);`
`3699`	`3695`	`}`
`3700`	`3696`	`else`
`3701`	`3697`	`{`
`3702`		`- elog(DEBUG1, "qsort_tuple");`
`3703`	`3698`	`qsort_tuple(state->memtuples,`
`3704`	`3699`	`state->memtupcount,`
`3705`	`3700`	`state->comparetup,`