Ensure that creation of an empty relfile is fsync'd at checkpoint.

hlinnaka · hlinnaka · commit 6377f705cab2 · 2023-07-04T18:08:40.000+03:00
If you create a table and don't insert any data into it, the relation file is never fsync'd. You don't lose data, because an empty table doesn't have any data to begin with, but if you crash and lose the file, subsequent operations on the table will fail with "could not open file" error. To fix, register an fsync request in mdcreate(), like we do for mdwrite(). Per discussion, we probably should also fsync the containing directory after creating a new file. But that's a separate and much wider issue. Backpatch to all supported versions. Reviewed-by: Andres Freund, Thomas Munro Discussion: https://www.postgresql.org/message-id/d47d8122-415e-425c-d0a2-e0160829702d%40iki.fi
diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
@@ -334,6 +334,9 @@ mdcreate(SMgrRelation reln, ForkNumber forkNum, bool isRedo)
 	mdfd = &reln->md_seg_fds[forkNum][0];
 	mdfd->mdfd_vfd = fd;
 	mdfd->mdfd_segno = 0;
+
+	if (!SmgrIsTemp(reln))
+		register_dirty_segment(reln, forkNum, mdfd);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,9 @@ mdcreate(SMgrRelation reln, ForkNumber forkNum, bool isRedo)`
`334`	`334`	`mdfd = &reln->md_seg_fds[forkNum][0];`
`335`	`335`	`mdfd->mdfd_vfd = fd;`
`336`	`336`	`mdfd->mdfd_segno = 0;`
	`337`	`+`
	`338`	`+ if (!SmgrIsTemp(reln))`
	`339`	`+ register_dirty_segment(reln, forkNum, mdfd);`
`337`	`340`	`}`
`338`	`341`
`339`	`342`	`/*`