8000 Correctly copy the target host identification in PQcancelCreate. · postgres/postgres@5d08000 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5d08000

Browse files
committed
Correctly copy the target host identification in PQcancelCreate.
PQcancelCreate failed to copy struct pg_conn_host's "type" field, instead leaving it zero (a/k/a CHT_HOST_NAME). This seemingly has no great ill effects if it should have been CHT_UNIX_SOCKET instead, but if it should have been CHT_HOST_ADDRESS then a null-pointer dereference will occur when the cancelConn is used. Bug: #18974 Reported-by: Maxim Boguk <maxim.boguk@gmail.com> Author: Sergei Kornilov <sk@zsrv.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/18974-575f02b2168b36b3@postgresql.org Backpatch-through: 17
1 parent 4938737 commit 5d08000

File tree

1 file changed

+1
-0
lines changed
< A89F /span>

1 file changed

+1
-0
lines changed

src/interfaces/libpq/fe-cancel.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ PQcancelCreate(PGconn *conn)
137137
goto oom_error;
138138

139139
originalHost = conn->connhost[conn->whichhost];
140+
cancelConn->connhost[0].type = originalHost.type;
140141
if (originalHost.host)
141142
{
142143
cancelConn->connhost[0].host = strdup(originalHost.host);

0 commit comments

Comments
 (0)
0