<
8000
script type="application/json" data-target="react-app.embeddedData">{"payload":{"commit":{"oid":"540f31680913b4e11f2caa40cafeca269cfcb22f","url":"/postgres/postgres/commit/540f31680913b4e11f2caa40cafeca269cfcb22f","authoredDate":"2019-10-01T16:53:04.000+02:00","committedDate":"2019-10-01T16:53:04.000+02:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eBlind attempt to fix pglz_maximum_compressed_size\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"Commit \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/postgres/postgres/commit/11a078cf87ffb611d19c7dec6df68b41084ad9c9/hovercard\" href=\"https://github.com/postgres/postgres/commit/11a078cf87ffb611d19c7dec6df68b41084ad9c9\"\u003e\u003ctt\u003e11a078c\u003c/tt\u003e\u003c/a\u003e triggered failures on big-endian machines, and the\nonly plausible place for an issue seems to be that TOAST_COMPRESS_SIZE\ncalls VARSIZE instead of VARSIZE_ANY. So try fixing that blindly.\n\nDiscussion: \u003ca href=\"https://www.postgresql.org/message-id/20191001131803.j6uin7nho7t6vxzy%40development\" rel=\"nofollow\"\u003ehttps://www.postgresql.org/message-id/20191001131803.j6uin7nho7t6vxzy%40development\u003c/a\u003e","authors":[{"login":"tvondra","displayName":"Tomas Vondra","avatarUrl":"https://avatars.githubusercontent.com/u/539575?v=4","path":"/tvondra","isGitHub":false}],"committerAttribution":false,"committer":{"login":"tvondra","displayName":"Tomas Vondra","avatarUrl":"https://avatars.githubusercontent.com/u/539575?v=4","path":"/tvondra","isGitHub":false},"parents":["fa2fe04bf1d4d31e099808745974964f84eb4521"],"globalRelayId":"MDY6Q29tbWl0OTI3NDQyOjU0MGYzMTY4MDkxM2I0ZTExZjJjYWE0MGNhZmVjYTI2OWNmY2IyMmY=","sha1":"fa2fe04bf1d4d31e099808745974964f84eb4521","sha2":"540f31680913b4e11f2caa40cafeca269cfcb22f"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":30,"text":"@@ -31,7 +31,7 @@ typedef struct toast_compress_header","html":"@@ -31,7 +31,7 @@ typedef struct toast_compress_header","displayNoNewLineWarning":false,"position":0,"left":30,"right":30},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":31,"text":" */","html":" \u003cspan class=pl-c\u003e */\u003c/span\u003e","displayNoNewLineWarning":false,"position":1,"left":31,"right":31},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":32,"text":" #define TOAST_COMPRESS_HDRSZ\t\t((int32) sizeof(toast_compress_header))","html":" \u003cspan class=pl-k\u003e#define\u003c/span\u003e \u003cspan class=pl-c1\u003eTOAST_COMPRESS_HDRSZ\u003c/span\u003e\t\t((int32) sizeof(toast_compress_header))","displayNoNewLineWarning":false,"position":2,"left":32,"right":32},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":33,"text":" #define TOAST_COMPRESS_RAWSIZE(ptr) (((toast_compress_header *) (ptr))-\u003erawsize)","html":" \u003cspan class=pl-k\u003e#define\u003c/span\u003e \u003cspan class=pl-en\u003eTOAST_COMPRESS_RAWSIZE\u003c/span\u003e(\u003cspan class=pl-s1\u003eptr\u003c/span\u003e) (((toast_compress_header *) (ptr))-\u0026gt;rawsize)","displayNoNewLineWarning":false,"position":3,"left":33,"right":33},{"stylingDirective":null,"type":"DELETION","blobLineNumber":34,"text":"-#define TOAST_COMPRESS_SIZE(ptr)\t((int32) VARSIZE(ptr) - TOAST_COMPRESS_HDRSZ)","html":"-\u003cspan class=\"pl-k\"\u003e#define\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eTOAST_COMPRESS_SIZE\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003eptr\u003c/span\u003e)\t((int32) \u003cspan class=\"x x-first x-last\"\u003eVARSIZE\u003c/span\u003e(ptr) - TOAST_COMPRESS_HDRSZ)","displayNoNewLineWarning":false,"position":4,"left":34,"right":33},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":34,"text":"+#define TOAST_COMPRESS_SIZE(ptr)\t((int32) VARSIZE_ANY(ptr) - TOAST_COMPRESS_HDRSZ)","html":"+\u003cspan class=\"pl-k\"\u003e#define\u003c/span\u003e \u003cspan class=\"pl-en\"\u003eTOAST_COMPRESS_SIZE\u003c/span\u003e(\u003cspan class=\"pl-s1\"\u003eptr\u003c/span\u003e)\t((int32) \u003cspan class=\"x x-first x-last\"\u003eVARSIZE_ANY\u003c/span\u003e(ptr) - TOAST_COMPRESS_HDRSZ)","displayNoNewLineWarning":false,"position":5,"left":34,"right":34},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":35,"text":" #define TOAST_COMPRESS_RAWDATA(ptr) \\","html":" \u003cspan class=pl-k\u003e#define\u003c/span\u003e \u003cspan class=pl-en\u003eTOAST_COMPRESS_RAWDATA\u003c/span\u003e(\u003cspan class=pl-s1\u003eptr\u003c/span\u003e) \\","displayNoNewLineWarning":false,"position":6,"left":35,"right":35},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":36,"text":" \t(((char *) (ptr)) + TOAST_COMPRESS_HDRSZ)","html":" \t(((char *) (ptr)) + TOAST_COMPRESS_HDRSZ)","displayNoNewLineWarning":false,"position":7,"left":36,"right":36},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":37,"text":" #define TOAST_COMPRESS_SET_RAWSIZE(ptr, len) \\","html":" \u003cspan class=pl-k\u003e#define\u003c/span\u003e \u003cspan class=pl-en\u003eTOAST_COMPRESS_SET_RAWSIZE\u003c/span\u003e(\u003cspan class=pl-s1\u003eptr\u003c/span\u003e, \u003cspan class=pl-s1\u003elen\u003c/span\u003e) \\","displayNoNewLineWarning":false,"position":8,"left":37,"right":37}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":55,"linesChanged":2,"newTreeEntry":{"lineCount":55,"path":"src/include/access/toast_internals.h","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/include/access/toast_internals.h","mode":100644},"linesAdded":1,"linesDeleted":1,"path":"src/include/access/toast_internals.h","pathDigest":"36e22fdca47584988b6dd1b0c04cf25123ff739a1c640d41fb8f5a416f1cf8a1","status":"MODIFIED","truncatedReason":null,"oldOid":"fa2fe04bf1d4d31e099808745974964f84eb4521","newOid":"540f31680913b4e11f2caa40cafeca269cfcb22f","copilotChatReference":null,"deletedSha":"fa2fe04bf1d4d31e099808745974964f84eb4521","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/540f31680913b4e11f2caa40cafeca269cfcb22f","fileTreeExpanded":true,"headerInfo":{"additions":1,"deletions":1,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":507,"lineShownCount":9},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"frmBcYpkcQs3YSjvfXzCCv-O_88rM6F6zO1RjFToTe9HV_L-sEXpnauhjwt-VMMCH4tbhCPux9b2IFxh4pK7gQ"},"/users/diffview?diff=unified":{"post":"WpHkQVuzCU_w7XdSuVTtyn6G_RyCdNw9g1a36CFsmYRjf5fOYZKR2Wwt0La6fOzCnoNZV4qpupG5m7oFlxZv6g"},"/notifications/thread":{"post":"bQ7pBh_G-bbAwfbmEjU-SYXw0JB8G4xYQQ9YH9-NlWa22N-JlYsbmL7-47r4QiJQJ2YsddLPs_EbeoilDI4LZQ"}}},"title":"Blind attempt to fix pglz_maximum_compressed_size · postgres/postgres@540f316","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
File tree Expand file tree Collapse file tree 1 file changed +1
-1
lines changed Expand file tree Collapse file tree 1 file changed +1
-1
lines changed Original file line number Diff line number Diff line change @@ -31,7 +31,7 @@ typedef struct toast_compress_header
3131 */
3232#define TOAST_COMPRESS_HDRSZ ((int32) sizeof(toast_compress_header))
3333#define TOAST_COMPRESS_RAWSIZE (ptr ) (((toast_compress_header *) (ptr))->rawsize)
34- #define TOAST_COMPRESS_SIZE (ptr ) ((int32) VARSIZE (ptr) - TOAST_COMPRESS_HDRSZ)
34+ #define TOAST_COMPRESS_SIZE (ptr ) ((int32) VARSIZE_ANY (ptr) - TOAST_COMPRESS_HDRSZ)
3535#define TOAST_COMPRESS_RAWDATA (ptr ) \
3636 (((char *) (ptr)) + TOAST_COMPRESS_HDRSZ)
3737#define TOAST_COMPRESS_SET_RAWSIZE (ptr , len ) \
You can’t perform that action at this time.
0 commit comments