You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<
8000
script type="application/json" data-target="react-app.embeddedData">{"payload":{"commit":{"oid":"404f49338fef32150f930ddfa8ae0411b5e35121","url":"/postgres/postgres/commit/404f49338fef32150f930ddfa8ae0411b5e35121","authoredDate":"2022-03-27T00:11:38.000+01:00","committedDate":"2022-03-27T00:11:38.000+01:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eWait for subscription to sync in t/031_column_list.sql\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"One of the TAP tests added in \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/postgres/postgres/commit/923def9a533a7d986acfb524139d8b9e5466d0a5/hovercard\" href=\"https://github.com/postgres/postgres/commit/923def9a533a7d986acfb524139d8b9e5466d0a5\"\u003e\u003ctt\u003e923def9\u003c/tt\u003e\u003c/a\u003e did not wait after creating a\nsubscription, and wait_for_catchup is not sufficient for this. So if the\ntablesync workers happen do not complete quickly enough, the test won't\nsee the expected results.\n\nThis probably explains intermittent failures on a couple buildfarm\nanimals (komodoensis, petalura and snapper).\n\nReported-by: Tom Lane\nDiscussion: \u003ca href=\"https://postgr.es/m/170549.1648330634@sss.pgh.pa.us\" rel=\"nofollow\"\u003ehttps://postgr.es/m/170549.1648330634@sss.pgh.pa.us\u003c/a\u003e","authors":[{"login":"tvondra","displayName":"Tomas Vondra","avatarUrl":"https://avatars.githubusercontent.com/u/539575?v=4","path":"/tvondra","isGitHub":false}],"committerAttribution":false,"committer":{"login":"tvondra","displayName":"Tomas Vondra","avatarUrl":"https://avatars.githubusercontent.com/u/539575?v=4","path":"/tvondra","isGitHub":false},"parents":["4a7e964fc67a541b6ea1b72729ad3f8e632d003c"],"globalRelayId":"C_kwDOAA4m0toAKDQwNGY0OTMzOGZlZjMyMTUwZjkzMGRkZmE4YWUwNDExYjVlMzUxMjE","sha1":"4a7e964fc67a541b6ea1b72729ad3f8e632d003c","sha2":"404f49338fef32150f930ddfa8ae0411b5e35121"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":721,"text":"@@ -722,7 +722,7 @@ sub wait_for_subscription_sync","html":"@@ -722,7 +722,7 @@ sub wait_for_subscription_sync","displayNoNewLineWarning":false,"position":0,"left":721,"right":721},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":722,"text":" \tCREATE SUBSCRIPTION sub1 CONNECTION '$publisher_connstr' PUBLICATION pub8;","html":" \u003cspan class=\"pl-s\"\u003e\tCREATE SUBSCRIPTION sub1 CONNECTION \u0026#39;\u003cspan class=\"pl-smi\"\u003e$publisher_connstr\u003c/span\u003e\u0026#39; PUBLICATION pub8;\u003c/span\u003e","displayNoNewLineWarning":false,"position":1,"left":722,"right":722},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":723,"text":" ));","html":" \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e)\u003c/span\u003e\u003c/span\u003e);","displayNoNewLineWarning":false,"position":2,"left":723,"right":723},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":724,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":3,"left":724,"right":724},{"stylingDirective":null,"type":"DELETION","blobLineNumber":725,"text":"-$node_publisher-\u003ewait_for_catchup('sub1');","html":"-\u003cspan class=\"pl-smi x x-first\"\u003e$node_publisher\u003c/span\u003e\u003cspan class=\"pl-k x\"\u003e-\u0026gt;\u003c/span\u003e\u003cspan class=\"x\"\u003ewait_for_catchup(\u003c/span\u003e\u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds x\"\u003e'\u003c/span\u003e\u003cspan class=\"x\"\u003esub1\u003c/span\u003e\u003cspan class=\"pl-pds x x-last\"\u003e'\u003c/span\u003e\u003c/span\u003e);","displayNoNewLineWarning":false,"position":4,"left":725,"right":724},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":725,"text":"+wait_for_subscription_sync($node_subscriber);","html":"+\u003cspan class=\"x x-first\"\u003ewait_for_subscription_sync(\u003c/span\u003e\u003cspan class=\"pl-smi x x-last\"\u003e$node_subscriber\u003c/span\u003e);","displayNoNewLineWarning":false,"position":5,"left":725,"right":725},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":726,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":6,"left":726,"right":726},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":727,"text":" $node_publisher-\u003esafe_psql('postgres', qq(","html":" \u003cspan class=\"pl-smi\"\u003e$node_publisher\u003c/span\u003e\u003cspan class=\"pl-k\"\u003e-\u0026gt;\u003c/span\u003esafe_psql(\u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003epostgres\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e, \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003eqq(\u003c/span\u003e\u003c/span\u003e","displayNoNewLineWarning":false,"position":7,"left":727,"right":727},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":728,"text":" \tINSERT INTO test_part_c VALUES (3, 7, 8);","html":" \u003cspan class=\"pl-s\"\u003e\tINSERT INTO test_part_c VALUES (3, 7, 8);\u003c/span\u003e","displayNoNewLineWarning":false,"position":8,"left":728,"right":728}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":1131,"linesChanged":2,"newTreeEntry":{"lineCount":1131,"path":"src/test/subscription/t/031_column_list.pl","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/test/subscription/t/031_column_list.pl","mode":100644},"linesAdded":1,"linesDeleted":1,"path":"src/test/subscription/t/031_column_list.pl","pathDigest":"377d49c8dafb85cf8676080316b998dd6ab9b4a8a77fb2ddefa77da9633da67a","status":"MODIFIED","truncatedReason":null,"oldOid":"4a7e964fc67a541b6ea1b72729ad3f8e632d003c","newOid":"404f49338fef32150f930ddfa8ae0411b5e35121","copilotChatReference":null,"deletedSha":"4a7e964fc67a541b6ea1b72729ad3f8e632d003c","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/404f49338fef32150f930ddfa8ae0411b5e35121","fileTreeExpanded":true,"headerInfo":{"additions":1,"deletions":1,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":315,"lineShownCount":9},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"m_lrg5OXpfErg0r0E2Losyc0bMJ6AZgAUvMNcxcZJkcZVNOE_KSAEunfltpMrgRDvUAbo4xzIaaAnMY78tmEYQ"},"/users/diffview?diff=unified":{"post":"m5tuiTrIJBZH5raUtaaD9ZuI6BpXuRcjJit37L3zHCYZNtaOVfsB9YW6arrqam8FAfyfe6HLroX0RLykWDO-AA"},"/notifications/thread":{"post":"992nZ3lvFKIqQOAcS1AtqXnjJbO3UsR9jyYgDIDhMJPdq1cV9q33AIqf6VJpwAe6OhYr2r3v7BuH2PRZLYdOYQ"}}},"title":"Wait for subscription to sync in t/031_column_list.sql · postgres/postgres@404f493","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
Wait for subscription to sync in t/031_column_list.sql
One of the TAP tests added in 923def9 did not wait after creating a
subscription, and wait_for_catchup is not sufficient for this. So if the
tablesync workers happen do not complete quickly enough, the test won't
see the expected results.
This probably explains intermittent failures on a couple buildfarm
animals (komodoensis, petalura and snapper).
Reported-by: Tom Lane
Discussion: https://postgr.es/m/170549.1648330634@sss.pgh.pa.us
0 commit comments