Silence compiler warnings from some older compilers.

tglsfdc · tglsfdc · commit 37290f7f5a9a · 2022-06-01T17:21:45.000-04:00
Since a117ceb, some older gcc versions issue "variable may be used uninitialized in this function" complaints for brin_summarize_range. Silence that using the same coding pattern as in bt_index_check_internal; arguably, a117ceb had too narrow a view of which compilers might give trouble. Nathan Bossart and Tom Lane. Back-patch as the previous commit was. Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
@@ -242,7 +242,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed)
 	else
 	{
 		heaprel = NULL;
-		/* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+		/* Set these just to suppress "uninitialized variable" warnings */
 		save_userid = InvalidOid;
 		save_sec_context = -1;
 		save_nestlevel = -1;
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
@@ -916,7 +916,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
 		save_nestlevel = NewGUCNestLevel();
 	}
 	else
+	{
 		heapRel = NULL;
+		/* Set these just to suppress "uninitialized variable" warnings */
+		save_userid = InvalidOid;
+		save_sec_context = -1;
+		save_nestlevel = -1;
+	}
 
 	indexRel = index_open(indexoid, ShareUpdateExclusiveLock);
 

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed)`
`242`	`242`	`else`
`243`	`243`	`{`
`244`	`244`	`heaprel = NULL;`
`245`		`- /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */`
	`245`	`+ /* Set these just to suppress "uninitialized variable" warnings */`
`246`	`246`	`save_userid = InvalidOid;`
`247`	`247`	`save_sec_context = -1;`
`248`	`248`	`save_nestlevel = -1;`