8000 Update comment about ExprState.escontext · postgres/postgres@3422f5f · GitHub
[go: up one dir, main page]
Skip to content

Commit 3422f5f

Browse files
amitlanamitlan
committed
Update comment about ExprState.escontext
The updated comment provides more helpful guidance by mentioning that escontext should be set when soft error handling is needed. Reported-by: Jian He <jian.universality@gmail.com> Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com Backpatch-through: 17
1 parent 7829f85 commit 3422f5f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎src/include/nodes/execnodes.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,10 @@ typedef struct ExprState
132132
bool *innermost_domainnull;
133133

134134
/*
135-
* For expression nodes that support soft errors. Should be set to NULL
136-
* before calling ExecInitExprRec() if the caller wants errors thrown.
135+
* For expression nodes that support soft errors. Should be set to NULL if
136+
* the caller wants errors to be thrown. Callers that do not want errors
137+
* thrown should set it to a valid ErrorSaveContext before calling
138+
* ExecInitExprRec().
137139
*/
138140
ErrorSaveContext *escontext;
139141
} ExprState;

0 commit comments

Comments
 (0)
0