<
8000
script type="application/json" data-target="react-app.embeddedData">{"payload":{"commit":{"oid":"27f7f81e4c8d5d390ea212d13b65ada8e4a232cd","url":"/postgres/postgres/commit/27f7f81e4c8d5d390ea212d13b65ada8e4a232cd","authoredDate":"2023-12-20T08:39:54.000+09:00","committedDate":"2023-12-20T08:39:54.000+09:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003ebasic_archive: Fix comments related to NO_INSTALLCHECK\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"These comments incorrectly referred to shared_preload_libraries as being\nrequired for the test to work.\n\nThinko in commit \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/postgres/postgres/commit/c68a1839902daeb42cf1ebc89edfdd91c00e5091/hovercard\" href=\"https://github.com/postgres/postgres/commit/c68a1839902daeb42cf1ebc89edfdd91c00e5091\"\u003e\u003ctt\u003ec68a183\u003c/tt\u003e\u003c/a\u003e.\n\nAuthor: Bharath Rupireddy\nDiscussion: \u003ca href=\"https://postgr.es/m/CALj2ACXpjFDiXf-L7AARQ4ppuxiDYSKZjyZb=wOa+cgg0zuWAw@mail.gmail.com\" rel=\"nofollow\"\u003ehttps://postgr.es/m/CALj2ACXpjFDiXf-L7AARQ4ppuxiDYSKZjyZb=wOa+cgg0zuWAw@mail.gmail.com\u003c/a\u003e","authors":[{"login":"michaelpq","displayName":"Michael Paquier","avatarUrl":"https://avatars.githubusercontent.com/u/985332?v=4","path":"/michaelpq","isGitHub":false}],"committerAttribution":false,"committer":{"login":"michaelpq","displayName":"Michael Paquier","avatarUrl":"https://avatars.githubusercontent.com/u/985332?v=4","path":"/michaelpq","isGitHub":false},"parents":["aafc07c7a191bc807c77fe2a044006a5db07faba"],"globalRelayId":"C_kwDOAA4m0toAKDI3ZjdmODFlNGM4ZDVkMzkwZWEyMTJkMTNiNjVhZGE4ZTRhMjMyY2Q","sha1":"aafc07c7a191bc807c77fe2a044006a5db07faba","sha2":"27f7f81e4c8d5d390ea212d13b65ada8e4a232cd"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":4,"text":"@@ -5,8 +5,9 @@ PGFILEDESC = \"basic_archive - basic archive module\"","html":"@@ -5,8 +5,9 @@ PGFILEDESC = \u0026quot;basic_archive - basic archive module\u0026quot;","displayNoNewLineWarning":false,"position":0,"left":4,"right":4},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":5,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":1,"left":5,"right":5},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":6,"text":" REGRESS = basic_archive","html":" \u003cspan class=\"pl-smi\"\u003eREGRESS\u003c/span\u003e = basic_archive","displayNoNewLineWarning":false,"position":2,"left":6,"right":6},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":7,"text":" REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/basic_archive/basic_archive.conf","html":" \u003cspan class=\"pl-smi\"\u003eREGRESS_OPTS\u003c/span\u003e = --temp-config \u003cspan class=\"pl-s\"\u003e$(\u003cspan class=\"pl-smi\"\u003etop_srcdir\u003c/span\u003e)\u003c/span\u003e/contrib/basic_archive/basic_archive.conf","displayNoNewLineWarning":false,"position":3,"left":7,"right":7},{"stylingDirective":null,"type":"DELETION","blobLineNumber":8,"text":"-# Disabled because these tests require \"shared_preload_libraries=basic_archive\",","html":"-\u003cspan class=\"pl-c\"\u003e\u003cspan class=\"pl-c\"\u003e#\u003c/span\u003e Disabled because these tests require \u0026quot;shared_preload_libraries=basic_archive\u0026quot;,\u003c/span\u003e","displayNoNewLineWarning":false,"position":4,"left":8,"right":7},{"stylingDirective":null,"type":"DELETION","blobLineNumber":9,"text":"-# which typical installcheck users do not have (e.g. buildfarm clients).","html":"-\u003cspan class=\"pl-c\"\u003e\u003cspan class=\"pl-c\"\u003e#\u003c/span\u003e which typical installcheck users do not have (e.g. buildfarm clients).\u003c/span\u003e","displayNoNewLineWarning":false,"position":5,"left":9,"right":7},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":8,"text":"+","html":"+","displayNoNewLineWarning":false,"position":6,"left":9,"right":8},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":9,"text":"+# Disabled because these tests require special configuration, which","html":"+\u003cspan class=\"pl-c\"\u003e\u003cspan class=\"pl-c\"\u003e#\u003c/span\u003e Disabled because these tests require special configuration, which\u003c/span\u003e","displayNoNewLineWarning":false,"position":7,"left":9,"right":9},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":10,"text":"+# typical installcheck users do not have (e.g. buildfarm clients).","html":"+\u003cspan class=\"pl-c\"\u003e\u003cspan class=\"pl-c\"\u003e#\u003c/span\u003e typical installcheck users do not have (e.g. buildfarm clients).\u003c/span\u003e","displayNoNewLineWarning":false,"position":8,"left":9,"right":10},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":11,"text":" NO_INSTALLCHECK = 1","html":" \u003cspan class=\"pl-smi\"\u003eNO_INSTALLCHECK\u003c/span\u003e = 1","displayNoNewLineWarning":false,"position":9,"left":10,"right":11},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":12,"text":" ","html":"\u003cbr\u003e","displayNoNewLineWarning":false,"position":10,"left":11,"right":12},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":13,"text":" ifdef USE_PGXS","html":" \u003cspan class=\"pl-k\"\u003eifdef\u003c/span\u003e \u003cspan class=\"pl-smi\"\u003eUSE_PGXS\u003c/span\u003e","displayNoNewLineWarning":false,"position":11,"left":12,"right":13}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":22,"linesChanged":5,"newTreeEntry":{"lineCount":22,"path":"contrib/basic_archive/Makefile","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"contrib/basic_archive/Makefile","mode":100644},"linesAdded":3,"linesDeleted":2,"path":"contrib/basic_archive/Makefile","pathDigest":"4db9c1843943a12c2c5b291ba8581e1f52fcc9c821f45d6e9d177a35fc474b98","status":"MODIFIED","truncatedReason":null,"oldOid":"aafc07c7a191bc807c77fe2a044006a5db07faba","newOid":"27f7f81e4c8d5d390ea212d13b65ada8e4a232cd","copilotChatReference":null,"deletedSha":"aafc07c7a191bc807c77fe2a044006a5db07faba","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null},{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":26,"text":"@@ -27,8 +27,8 @@ tests += {","html":"@@ -27,8 +27,8 @@ tests += {","displayNoNewLineWarning":false,"position":0,"left":26,"right":26},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":27,"text":" 'regress_args': [","html":" \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003eregress_args\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e: [","displayNoNewLineWarning":false,"position":1,"left":27,"right":27},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":28,"text":" '--temp-config', files('basic_archive.conf'),","html":" \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e--temp-config\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e, \u003cspan class=\"pl-c1\"\u003efiles\u003c/span\u003e(\u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003ebasic_archive.conf\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e),","displayNoNewLineWarning":false,"position":2,"left":28,"right":28},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":29,"text":" ],","html":" ],","displayNoNewLineWarning":false,"position":3,"left":29,"right":29},{"stylingDirective":null,"type":"DELETION","blobLineNumber":30,"text":"- # Disabled because these tests require \"shared_preload_libraries=basic_archive\",","html":"- \u003cspan class=\"pl-c\"\u003e# Disabled because these tests require \u003cspan class=\"x x-first x-last\"\u003e\"shared_preload_libraries=basic_archive\",\u003c/span\u003e\u003c/span\u003e","displayNoNewLineWarning":false,"position":4,"left":30,"right":29},{"stylingDirective":null,"type":"DELETION","blobLineNumber":31,"text":"- # which typical runningcheck users do not have (e.g. buildfarm clients).","html":"- \u003cspan class=\"pl-c\"\u003e# \u003cspan class=\"x x-first x-last\"\u003ewhich \u003c/span\u003etypical \u003cspan class=\"x x-first x-last\"\u003erunningcheck\u003c/span\u003e users do not have (e.g. buildfarm clients).\u003c/span\u003e","displayNoNewLineWarning":false,"position":5,"left":31,"right":29},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":30,"text":"+ # Disabled because these tests require special configuration, which","html":"+ \u003cspan class=\"pl-c\"\u003e# Disabled because these tests require \u003cspan class=\"x x-first x-last\"\u003especial configuration, which\u003c/span\u003e\u003c/span\u003e","displayNoNewLineWarning":false,"position":6,"left":31,"right":30},{"stylingDirective":null,"type":"ADDITION","blobLineNumber":31,"text":"+ # typical installcheck users do not have (e.g. buildfarm clients).","html":"+ \u003cspan class=\"pl-c\"\u003e# typical \u003cspan class=\"x x-first x-last\"\u003einstallcheck\u003c/span\u003e users do not have (e.g. buildfarm clients).\u003c/span\u003e","displayNoNewLineWarning":false,"position":7,"left":31,"right":31},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":32,"text":" 'runningcheck': false,","html":" \u003cspan class=\"pl-s\"\u003e\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003erunningcheck\u003cspan class=\"pl-pds\"\u003e\u0026#39;\u003c/span\u003e\u003c/span\u003e: \u003cspan class=\"pl-c1\"\u003efalse\u003c/span\u003e,","displayNoNewLineWarning":false,"position":8,"left":32,"right":32},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":33,"text":" },","html":" },","displayNoNewLineWarning":false,"position":9,"left":33,"right":33},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":34,"text":" }","html":" }","displayNoNewLineWarning":false,"position":10,"left":34,"right":34}],"diffNumber":1,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":34,"linesChanged":4,"newTreeEntry":{"lineCount":34,"path":"contrib/basic_archive/meson.build","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"contrib/basic_archive/meson.build","mode":100644},"linesAdded":2,"linesDeleted":2,"path":"contrib/basic_archive/meson.build","pathDigest":"9f42fbc40a76208ff2fb73060957bedaa5a33a8f5c2373b7b3a29a85b6af8a51","status":"MODIFIED","truncatedReason":null,"oldOid":"aafc07c7a191bc807c77fe2a044006a5db07faba","newOid":"27f7f81e4c8d5d390ea212d13b65ada8e4a232cd","copilotChatReference":null,"deletedSha":"aafc07c7a191bc807c77fe2a044006a5db07faba","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/27f7f81e4c8d5d390ea212d13b65ada8e4a232cd","fileTreeExpanded":true,"headerInfo":{"additions":5,"deletions":4,"filesChanged":2,"filesChangedString":"2"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":2,"truncated":false,"byteCount":971,"lineShownCount":23},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"GEYoUYI22jdJUxOPes4bHN-XFJ2bMeIYlpqWVkg11T9rkW3xHNBWswbC9q0cstAuWAjFfh385hSVuzJPStPTfw"},"/users/diffview?diff=unified":{"post":"HTjzx37UrRmgGuVUEbyofcKa1L9H85ncc2Fps9abD-5u77Zn4DIhne-LAHZ3wGNPRQUFXME-ndBwQM2q1H0Jrg"},"/notifications/thread":{"post":"RYgHAiLHqaHWpo-CA4aSOy0HbywPgPL5DfqLY8NDwY-cO4Psv2qyIwagt0yWv--aTS6LdN6QXp2d8YD-Y81Ibw"}}},"title":"basic_archive: Fix comments related to NO_INSTALLCHECK · postgres/postgres@27f7f81","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
File tree Expand file tree Collapse file tree 2 files changed +5
-4
lines changed Expand file tree Collapse file tree 2 files changed +5
-4
lines changed Original file line number Diff line number Diff line change @@ -5,8 +5,9 @@ PGFILEDESC = "basic_archive - basic archive module"
55
66REGRESS = basic_archive
77REGRESS_OPTS = --temp-config $(top_srcdir ) /contrib/basic_archive/basic_archive.conf
8- # Disabled because these tests require "shared_preload_libraries=basic_archive",
9- # which typical installcheck users do not have (e.g. buildfarm clients).
8+
9+ # Disabled because these tests require special configuration, which
10+ # typical installcheck users do not have (e.g. buildfarm clients).
1011NO_INSTALLCHECK = 1
1112
1213ifdef USE_PGXS
Original file line number Diff line number Diff line change @@ -27,8 +27,8 @@ tests += {
2727 ' regress_args'
2828 ' --temp-config' files (' basic_archive.conf'
2929 ],
30- # Disabled because these tests require "shared_preload_libraries=basic_archive",
31- # which typical runningcheck users do not have (e.g. buildfarm clients).
30+ # Disabled because these tests require special configuration, which
31+ # typical installcheck users do not have (e.g. buildfarm clients).
3232 ' runningcheck' false ,
3333 },
3434}
You can’t perform that action at this time.
0 commit comments