<
8000
script type="application/json" data-target="react-app.embeddedData">{"payload":{"commit":{"oid":"13b345df6438f222daf56eee86cb272628d1f1c3","url":"/postgres/postgres/commit/13b345df6438f222daf56eee86cb272628d1f1c3","authoredDate":"2023-01-17T20:03:35.000+01:00","committedDate":"2023-01-17T20:06:06.000+01:00","shortMessage":null,"shortMessageMarkdown":"\u003cdiv\u003eRemove AggregateRelationId from recordExtObjInitPriv()\u003c/div\u003e","shortMessageMarkdownLink":null,"bodyMessageHtml":"This was erroneous, because AggregateRelationId has no OID, so it\ncannot be part of an extension directly. (Aggregates are registered\nvia pg_proc.) No harm in practice, but better to make it correct.\n\nReviewed-by: Nathan Bossart \u0026lt;nathandbossart@gmail.com\u0026gt;\nDiscussion: \u003ca href=\"https://www.postgresql.org/message-id/flat/504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com\" rel=\"nofollow\"\u003ehttps://www.postgresql.org/message-id/flat/504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com\u003c/a\u003e","authors":[{"login":"petere","displayName":"Peter Eisentraut","avatarUrl":"https://avatars.githubusercontent.com/u/105543?v=4","path":"/petere","isGitHub":false}],"committerAttribution":false,"committer":{"login":"petere","displayName":"Peter Eisentraut","avatarUrl":"https://avatars.githubusercontent.com/u/105543?v=4","path":"/petere","isGitHub":false},"parents":["15eb1228800a35042ef318f941173aa8b89002d1"],"globalRelayId":"C_kwDOAA4m0toAKDEzYjM0NWRmNjQzOGYyMjJkYWY1NmVlZTg2Y2IyNzI2MjhkMWYxYzM","sha1":"15eb1228800a35042ef318f941173aa8b89002d1","sha2":"13b345df6438f222daf56eee86cb272628d1f1c3"},"currentUser":null,"repo":{"id":927442,"defaultBranch":"master","name":"postgres","ownerLogin":"postgres","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-09-21T11:35:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/177543?v=4","public":true,"private":false,"isOrgOwned":true},"diffEntryData":[{"diffLines":[{"stylingDirective":null,"type":"HUNK","blobLineNumber":4509,"text":"@@ -4510,7 +4510,6 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)","html":"@@ -4510,7 +4510,6 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)","displayNoNewLineWarning":false,"position":0,"left":4509,"right":4509},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4510,"text":" \t\tReleaseSysCache(tuple);","html":" \t\t\u003cspan class=pl-en\u003eReleaseSysCache\u003c/span\u003e(\u003cspan class=pl-s1\u003etuple\u003c/span\u003e);","displayNoNewLineWarning":false,"position":1,"left":4510,"right":4510},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4511,"text":" \t}","html":" \t}","displayNoNewLineWarning":false,"position":2,"left":4511,"right":4511},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4512,"text":" \telse if (classoid == AccessMethodRelationId ||","html":" \t\u003cspan class=pl-k\u003eelse\u003c/span\u003e \u003cspan class=pl-k\u003eif\u003c/span\u003e (\u003cspan class=pl-s1\u003eclassoid\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-s1\u003eAccessMethodRelationId\u003c/span\u003e \u003cspan class=pl-c1\u003e||\u003c/span\u003e","displayNoNewLineWarning":false,"position":3,"left":4512,"right":4512},{"stylingDirective":null,"type":"DELETION","blobLineNumber":4513,"text":"-\t\t\t classoid == AggregateRelationId ||","html":"-\t\t\t \u003cspan class=pl-s1\u003eclassoid\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-s1\u003eAggregateRelationId\u003c/span\u003e \u003cspan class=pl-c1\u003e||\u003c/span\u003e","displayNoNewLineWarning":false,"position":4,"left":4513,"right":4512},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4513,"text":" \t\t\t classoid == CastRelationId ||","html":" \t\t\t \u003cspan class=pl-s1\u003eclassoid\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-s1\u003eCastRelationId\u003c/span\u003e \u003cspan class=pl-c1\u003e||\u003c/span\u003e","displayNoNewLineWarning":false,"position":5,"left":4514,"right":4513},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4514,"text":" \t\t\t classoid == CollationRelationId ||","html":" \t\t\t \u003cspan class=pl-s1\u003eclassoid\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-s1\u003eCollationRelationId\u003c/span\u003e \u003cspan class=pl-c1\u003e||\u003c/span\u003e","displayNoNewLineWarning":false,"position":6,"left":4515,"right":4514},{"stylingDirective":null,"type":"CONTEXT","blobLineNumber":4515,"text":" \t\t\t classoid == ConversionRelationId ||","html":" \t\t\t \u003cspan class=pl-s1\u003eclassoid\u003c/span\u003e \u003cspan class=pl-c1\u003e==\u003c/span\u003e \u003cspan class=pl-s1\u003eConversionRelationId\u003c/span\u003e \u003cspan class=pl-c1\u003e||\u003c/span\u003e","displayNoNewLineWarning":false,"position":7,"left":4516,"right":4515}],"diffNumber":0,"diffSize":"0 Bytes","isBinary":false,"isTooBig":false,"collapsed":false,"isSubmodule":false,"lineCount":4746,"linesChanged":1,"newTreeEntry":{"lineCount":4746,"path":"src/backend/catalog/aclchk.c","mode":100644,"isGenerated":false},"oldTreeEntry":{"lineCount":0,"path":"src/backend/catalog/aclchk.c","mode":100644},"linesAdded":0,"linesDeleted":1,"path":"src/backend/catalog/aclchk.c","pathDigest":"da7c755c78a1dbd6d18d5a42e45f478002c96de8d72a6193cbffb3a82c0d888b","status":"MODIFIED","truncatedReason":null,"oldOid":"15eb1228800a35042ef318f941173aa8b89002d1","newOid":"13b345df6438f222daf56eee86cb272628d1f1c3","copilotChatReference":null,"deletedSha":"15eb1228800a35042ef318f941173aa8b89002d1","canToggleRichDiff":false,"defaultToRichDiff":false,"proseDifffHtml":null,"renderInfo":null,"dependencyDiffPath":null,"submodule":null}],"splitViewPreference":"unified","ignoreWhitespace":false,"repoOwnerGlobalRelayId":"MDEyOk9yZ2FuaXphdGlvbjE3NzU0Mw==","commentsPreference":"visible","diffLineSpacingPreference":"relaxed","useMonospaceFont":false,"pasteUrlLinkAsPlainText":false,"userNotices":[],"path":"/postgres/postgres/commit/13b345df6438f222daf56eee86cb272628d1f1c3","fileTreeExpanded":true,"headerInfo":{"additions":0,"deletions":1,"filesChanged":1,"filesChangedString":"1"},"moreDiffsToLoad":false,"asyncDiffLoadInfo":{"startIndex":1,"truncated":false,"byteCount":304,"lineShownCount":8},"commentInfo":{"canComment":false,"locked":false,"canLock":false,"repoArchived":false},"csrf_tokens":{"/users/diffview?diff=split":{"post":"eCJpH1V_QcMKNnV-TMOPiWDxEELXq3ASMzKtJSXmLY_G7GmBb0_X14Kj5jGH0qYsrPCvLXUSJkMNkyRLZaLu5A"},"/users/diffview?diff=unified":{"post":"WY_O84F-NJbYn31GJ-Kk9EQLR96gh7TA_XBYSu2hvQnnQc5tu06iglAK7gns841RiAr4sQI-4pHD0dEkreV-Yg"},"/notifications/thread":{"post":"OtZFI-iCwfGfvxnE76UaB2pAFTBLZFuNkMuWTKWs0UM9arKjjkTnehY2FUTd9XLU8VqGku4uR1UFSMNe8T5VkA"}}},"title":"Remove AggregateRelationId from recordExtObjInitPriv() · postgres/postgres@13b345d","appPayload":{"helpUrl":"https://docs.github.com","findInDiffWorkerPath":"/assets-cdn/worker/find-in-diff-worker-2bfe39677d14.js","enabled_features":{"diff_ux_refresh_beta":false,"diff_inline_comments":true,"diff_ux_refresh_ssr_five":false,"diff_ux_refresh_ssr_ten":false,"react_diff_line_type_character_correction":true}}}
File tree Expand file tree Collapse file tree 1 file changed +0
-1
lines changed Expand file tree Collapse file tree 1 file changed +0
-1
lines changed Original file line number Diff line number Diff line change @@ -4510,7 +4510,6 @@ recordExtObjInitPriv(Oid objoid, Oid classoid)
45104510 ReleaseSysCache (tuple );
45114511 }
45124512 else if (classoid == AccessMethodRelationId ||
4513- classoid == AggregateRelationId ||
45144513 classoid == CastRelationId ||
45154514 classoid == CollationRelationId ||
45164515 classoid == ConversionRelationId ||
You can’t perform that action at this time.
0 commit comments