8000 pg_upgrade: Add C comment about NextXID delimiter · postgres/postgres@13a6fa3 · GitHub
[go: up one dir, main page]
Skip to content

Commit 13a6fa3

Browse files
bmomjianbmomjian
committed
pg_upgrade: Add C comment about NextXID delimiter
We don't test the catversion for the NextXID delimiter change, we just test the string contents; explain why. Reported-by: Michael Paquier
1 parent 59a884e commit 13a6fa3

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

‎src/bin/pg_upgrade/controldata.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,14 @@ get_control_data(ClusterInfo *cluster, bool live_check)
197197
p++; /* remove ':' char */
198198
cluster->controldata.chkpnt_nxtepoch = str2uint(p);
199199

200+
/*
201+
* Delimiter changed from '/' to ':' in 9.6. We don't test for
202+
* the catalog version of the change because the catalog version
203+
* is pulled from pg_controldata too, and it isn't worth adding
204+
* an order dependency for this --- we just check the string.
205+
*/
200206
if (strchr(p, '/') != NULL)
201207
p = strchr(p, '/');
202-
/* delimiter changed from '/' to ':' in 9.6 */
203208
else if (GET_MAJOR_VERSION(cluster->major_version) >= 906)
204209
p = strchr(p, ':');
205210
else

0 commit comments

Comments
 (0)
0