8000 Relax overly strict sanity check for upgraded ancient databases · postgres/postgres@0ddaaa4 · GitHub
[go: up one dir, main page]
Skip to content
8000

Commit 0ddaaa4

Browse files
alvherrealvherre
committed
Relax overly strict sanity check for upgraded ancient databases
Commit 4800f16 added some sanity checks to ensure we don't accidentally corrupt data, but in one of them we failed to consider the effects of a database upgraded from 9.2 or earlier, where a tuple exclusively locked prior to the upgrade has a slightly different bit pattern. Fix that by using the macro that we fixed in commit 74ebba8 for similar situations. Reported-by: Alexandre Garcia Reviewed-by: Andres Freund Discussion: https://postgr.es/m/CAPYLKR6yxV4=pfW0Gwij7aPNiiPx+3ib4USVYnbuQdUtmkMaEA@mail.gmail.com Andres suspects that this bug may have wider ranging consequences, but I couldn't find anything.
1 parent 3f26be8 commit 0ddaaa4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/backend/access/heap/heapam.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6783,7 +6783,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple,
67836783
* independent of committedness, since a committed lock holder has
67846784
* released the lock).
67856785
*/
6786-
if (!(tuple->t_infomask & HEAP_XMAX_LOCK_ONLY) &&
6786+
if (!HEAP_XMAX_IS_LOCKED_ONLY(tuple->t_infomask) &&
67876787
TransactionIdDidCommit(xid))
67886788
ereport(ERROR,
67896789
(errcode(ERRCODE_DATA_CORRUPTED),

0 commit comments

Comments
 (0)
0