8000 Stabilize results of insert-conflict-toast.spec. · postgres/postgres@024e064 · GitHub
[go: up one dir, main page]
Skip to content

Commit 024e064

Browse files
tglsfdctglsfdc
committed
Stabilize results of insert-conflict-toast.spec.
This back-branch test script was later absorbed into insert-conflict-specconflict.spec, which required some stabilization in commit 741d7f1, so perhaps it's not surprising that it needs a bit of love too. It's odd though that we hadn't seen it fail before now, because I thought that 741d7f1 did not change isolationtester's timing behavior for scripts without any annotation markers. In any case, this script is racy on its face, so add an annotation to force stable reporting order. Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=piculet&dt=2021-06-24%2009%3A54%3A56 Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2021-06-24%2010%3A10%3A00
1 parent fbbc489 commit 024e064

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

‎src/test/isolation/specs/insert-conflict-toast.spec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,8 @@ step s3insert {
4848
INSERT INTO ctoast (key, val) VALUES (1, ctoast_large_val()) ON CONFLICT DO NOTHING;
4949
}
5050

51-
permutation s2insert s3insert s1commit
51+
# s1's commit will release s2 and s3 at the same time, so there's a
52+
# race condition as to which finishes first. Annotate the permutation
53+
# to always report s2 first.
54+
55+
permutation s2insert s3insert(s2insert) s1commit

0 commit comments

Comments
 (0)
0