python 2 test lint

avishalom · avishalom · commit 318ebc75ad82 · 2018-03-18T23:42:31.000-04:00
diff --git a/firebase_admin/dynamic_links.py b/firebase_admin/dynamic_links.py
@@ -114,8 +114,9 @@ def __init__(self, app):
 
     def _populated_request(self, url, options):
         days = options.duration_days
+        # This is due to six.urllib_parse mistaken error for python 2
         #pylint: disable=too-many-function-args
-        # This is due to six.urllib_parse incompatibility
+        # Complaints about the named second argument needed to replace "/"
         #pylint: disable=redundant-keyword-arg
         url_quoted = urllib_parse.quote(url, safe="")
         #pylint: enable=redundant-keyword-arg
diff --git a/tests/test_dynamic_links.py b/tests/test_dynamic_links.py
@@ -196,13 +196,13 @@ def test_invalid_event_stats_list(self, arg):
         with pytest.raises(ValueError) as excinfo:
             dynamic_links.LinkStats(arg)
         assert'Must be a list or tuple' in str(excinfo.value)
-    
-    @pytest.mark.parametrize('arg', [list([1,2]), list('asdf'), tuple([1,2])])
+
+    @pytest.mark.parametrize('arg', [list([1, 2]), list('asdf'), tuple([1, 2])])
     def test_empty_event_stats_list(self, arg):
         with pytest.raises(ValueError) as excinfo:
             dynamic_links.LinkStats(arg)
         assert'elements of event stats must be "EventStats"' in str(excinfo.value)
-        
+
 
 class TestQuoting(object):
     def test_quote(self):
