8000 Non-determinism of `mode` for a plotly express line plot with markers · Issue #4428 · plotly/plotly.py · GitHub
[go: up one dir, main page]
Skip to content

Non-determinism of mode for a plotly express line plot with markers #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alev000 opened this issue Nov 17, 2023 · 1 comment
Closed

Non-determinism of mode for a plotly express line plot with markers #4428

alev000 opened this issue Nov 17, 2023 · 1 comment

Comments

@alev000
Copy link
Contributor
alev000 commented Nov 17, 2023

The following block of code introduces nondeterminism in the mode of a plotly express trace, because it involves iterating over a set:
https://github.com/plotly/plotly.py/blob/v5.18.0/packages/python/plotly/plotly/express/_core.py#L1922-L1931

Among other things, this causes the output of plotly.graph_objects.Figure.to_html to be non-deterministic, because sometimes the mode for a line plot with markers is "lines+markers" and other times it is "markers+lines". This makes it difficult to test for consistency of results during automated tests.

One potential solution might be to replace the following:

-        trace_patch["mode"] = "+".join(modes)
+        trace_patch["mode"] = "+".join(sorted(modes))

Alternatively, modes could be constructed as a list instead of a set.
@alexcjohnson
Copy link
Collaborator

Nice find @alev000 - seems like a good solution, feel free to make a PR

@alev000 alev000 mentioned this issue Nov 17, 2023
Merged
5 tasks
@alev000 alev000 closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcjohnson @alev000
0