No type check for array_attrables, add test for a hover_data dictionary

guyrosin · guyrosin · commit e2a7cb4d97c6 · 2023-08-15T01:03:09.000+03:00
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -1423,9 +1423,7 @@ def build_dataframe(args, constructor):
                     i for i in args.values() if isinstance(i, str) and i in columns
                 ]
                 for field in args:
-                    if field in array_attrables and isinstance(
-                        args[field], (list, dict)
-                    ):
+                    if args[field] is not None and field in array_attrables:
                         necessary_columns.extend(
                             [i for i in args[field] if i in columns]
                         )
diff --git a/packages/python/plotly/plotly/tests/test_optional/test_px/test_px_input.py b/packages/python/plotly/plotly/tests/test_optional/test_px/test_px_input.py
@@ -332,7 +332,10 @@ def test_build_df_from_vaex_and_polars(test_lib):
     reason="plotly doesn't use a dataframe interchange protocol for pandas < 2.0.2",
 )
 @pytest.mark.parametrize("test_lib", ["vaex", "polars"])
-def test_build_df_with_hover_data_from_vaex_and_polars(test_lib):
+@pytest.mark.parametrize(
+    "hover_data", [["sepal_width"], {"sepal_length": False, "sepal_width": ":.2f"}]
+)
+def test_build_df_with_hover_data_from_vaex_and_polars(test_lib, hover_data):
     if test_lib == "vaex":
         import vaex as lib
     else:
@@ -345,7 +348,7 @@ def test_build_df_with_hover_data_from_vaex_and_polars(test_lib):
         data_frame=iris_vaex,
         x="petal_width",
         y="sepal_length",
-        hover_data=["sepal_width"],
+        hover_data=hover_data,
     )
     out = build_dataframe(args, go.Scatter)
     assert_frame_equal(

Original file line number	Diff line number	Diff line change
`@@ -1423,9 +1423,7 @@ def build_dataframe(args, constructor):`
`1423`	`1423`	`i for i in args.values() if isinstance(i, str) and i in columns`
`1424`	`1424`	`]`
`1425`	`1425`	`for field in args:`
`1426`		`- if field in array_attrables and isinstance(`
`1427`		`- args[field], (list, dict)`
`1428`		`- ):`
	`1426`	`+ if args[field] is not None and field in array_attrables:`
`1429`	`1427`	`necessary_columns.extend(`
`1430`	`1428`	`[i for i in args[field] if i in columns]`
`1431`	`1429`	`)`