8000 plotly.js image test by etpinard · Pull Request #7 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

plotly.js image test #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
etpinard merged 68 commits into from
Nov 17, 2015
Merged

plotly.js image test #7

etpinard merged 68 commits into from
Nov 17, 2015

Conversation

@etpinard
Copy link
Contributor
@etpinard etpinard commented Nov 17, 2015

etpinard and others added 30 commits November 13, 2015 13:55
@etpinard
put build-baseline-images in tasks/
3a3382e
@etpinard
put image request options getter in tasks/util
3bbe42d
@etpinard
add image server path to tasks/util/constants.js
407fa49
@etpinard
update pixel comp script:
346b55f 
- rename to compare_pixels_test.js
- use constants to resolves paths
- rm server_app error msg
@etpinard
add npm run test-image script
40a9c00
@perigee
fix path
beb5490
@etpinard
mv 3d mocks to test/image/mocks
1d31653
@perigee
update doc
a3d719d
@etpinard
mv gl2d testplots to test/image/mocks
563f14a
@etpinard
rm remains of testplot-*
f14fd76
@etpinard
use mock in mocks/ for pummel dashbaord button
2038690
@etpinard
rename and clean up test dashboard button lists
f8c0a90
@etpinard
rm data-ref annotations from gl2d mocks
d755422
@etpinard
fix path in gl2d test buttons
e92f04a
@etpinard
image test README to test/image
60efb07
@etpinard
Merge branch 'master' into image-test
708c6e5
@etpinard
make gl2d mocks valid JSON
e7691c2
@etpinard
put image viewer in functional state
6de726c
@perigee
Update README.md
1bb53f0 
update the doc
@etpinard
tmp commit git diff --cached!
1179ed1
@perigee
mv docker part doc to docker_part_readme.md
cc99801
@perigee
mv docker part doc to docker_part_readme.md
bf05f6c
@etpinard
add image docker test bash wrapper in tasks/
5e41e5a
@etpinard
add make baseline script
93d1be6
@etpinard
Merge branch 'image-test' of github.com:plotly/plotly.js into image-test
7352e87
@etpinard
Merge branch 'master' into image-test
f5ed930
@etpinard
add scroll-bar to image viewer buttons
da056c5
@etpinard
make image server inder look for plotly.js in build/
e2b2b41
@etpinard
update docker docs
a0158fa
@perigee
add sample circleci config file
efee288
perigee and others added 19 commits November 16, 2015 19:31
@perigee
add service
03d2012
@etpinard
rm preprocess in cibuild script (already done on postinstall)
769117c
@etpinard
make gl2d buttons the default in test_dashboard
0cce8d2
@etpinard
Merge branch 'image-test' of github.com:plotly/plotly.js into image-test
cf9f2c3
@etpinard
try putting 'monit restart' in same docker run cmd as test
0f787af
@perigee
add sudo
adb546f
@perigee
merge
7d72bc6
@perigee
comment out
d0de8a7
@etpinard
rm monit restart cmd in circle yml
5cc9b92
@etpinard
[testing] make grid line color by red by default
c2fe95e
@etpinard
bump sleep time to 20 after docker run
393b969
@etpinard
try image 0.2.0
fa92c36
@etpinard
try running cibuild in 'post'
d59fdd9
@etpinard
cp test/image index.html to image server
2a03509
@perigee
split the commands
8b19f4c
@perigee
use image 0.2.1 instead
a7e2594
@perigee
Revert "[testing] make grid line color by red by default"
dc2121e 
This reverts commit c2fe95e.
@perigee
move docker run into dependencies sector
a1be235
@etpinard
rm branch-only circle spec
036577b
etpinard
etpinard reviewed Nov 17, 2015
View reviewed changes
circle.yml
Copy link
Contributor Author
@etpinard etpinard Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command runs the image test inside the docker container.

etpinard
etpinard reviewed Nov 17, 2015
View reviewed changes
test/image/README.md
Copy link
Contributor Author
@etpinard etpinard Nov 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @alexcjohnson @cldougl @bpostlethwaite

@chriddyp
Copy link
Member
chriddyp commented Nov 17, 2015

beautifully done 💃

etpinard added a commit that referenced this pull request Nov 17, 2015
@etpinard
Merge pull request #7 from plotly/image-test
4e9a7ca 
plotly.js image test
@etpinard etpinard merged commit 4e9a7ca into master Nov 17, 2015
@etpinard etpinard deleted the image-test branch November 17, 2015 02:41
@snyk-bot snyk-bot mentioned this pull request Jul 5, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jul 14, 2022
Open
gvwilson added a commit that referenced this pull request Oct 8, 2025
@gvwilson
Merge pull request #7 from daexs/clean-up-mkdocs-build
0a4f3b5 
refactor: move documentation generation into the root directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@etpinard @chriddyp @perigee
0