8000 SVG trace on selection perf by etpinard · Pull Request #2583 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

SVG trace on selection perf #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 1, 2018
Merged

SVG trace on selection perf #2583

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
53a5a64
lookup in _plots instead of indexOf in array of ids
etpinard Apr 19, 2018
b6d4ebc
add 'styleOnSelect' method to Scatter* module
etpinard Apr 26, 2018
6c86e08
split Box & Bar .style + add .styleOnSelect
etpinard Apr 26, 2018
0a50295
use Scatter.selectOnStyle directly for violin traces
etpinard Apr 26, 2018
7103fab
add styleOnSelect for geo traces
etpinard Apr 27, 2018
01df2d2
style selected text nodes with selectedTextStyle + add test
etpinard Apr 30, 2018
3776e8f
refactor selected points drawing methods
etpinard Apr 30, 2018
4adc091
add styleOnSelect test
etpinard Apr 30, 2018
46858a7
Merge branch 'master' into scatter-select-perf
etpinard Apr 30, 2018
0e91c6e
lint (fn rename)
etpinard Apr 30, 2018
84ca51f
fixup merge master commit (candlestick can't use Box.styleOnSelect)
etpinard Apr 30, 2018
3e32b23
minor perf boost in Drawing.selectedPointStyle
etpinard Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint (fn rename)
  • Loading branch information
@etpinard
etpinard committed Apr 30, 2018
commit 0e91c6e422d3c81bade5e44ec87c92782d8c27fc
6 changes: 3 additions & 3 deletions src/plots/cartesian/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,19 +405,19 @@ function updateSelectedState(gd, searchTraces, eventData) {
var item0 = items[0];
var trace0 = item0.cd[0].trace;
var _module = item0._module;
var fn = _module.styleOnSelect || _module.style;
var styleSelection = _module.styleOnSelect || _module.style;

if(Registry.traceIs(trace0, 'regl')) {
// plot regl traces per module
var cds = new Array(len);
for(j = 0; j < len; j++) {
cds[j] = items[j].cd;
}
fn(gd, cds);
styleSelection(gd, cds);
} else {
// plot svg trace per trace
for(j = 0; j < len; j++) {
fn(gd, items[j].cd);
styleSelection(gd, items[j].cd);
}
}
}
Expand Down
0