8000 Plotly.purge in parcoords_test by alexcjohnson · Pull Request #2406 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content
8000

Plotly.purge in parcoords_test #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
try purge in afterEach in parcoords_test
  • Loading branch information
alexcjohnson committed Feb 27, 2018
commit ec69aa63b6d57d8bb692bef6c8b96939b494f098
12 changes: 9 additions & 3 deletions test/jasmine/tests/parcoords_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ var Parcoords = require('@src/traces/parcoords');
var attributes = require('@src/traces/parcoords/attributes');

var createGraphDiv = require('../assets/create_graph_div');
var delay = require('../assets/delay');
var destroyGraphDiv = require('../assets/destroy_graph_div');
var fail = require('../assets/fail_test');
var mouseEvent = require('../assets/mouse_event');
Expand Down Expand Up @@ -239,15 +240,20 @@ describe('parcoords initialization tests', function() {
});

describe('@gl parcoords', function() {

beforeAll(function() {
mock.data[0].dimensions.forEach(function(d) {
d.values = d.values.slice(lineStart, lineStart + lineCount);
});
mock.data[0].line.color = mock.data[0].line.color.slice(lineStart, lineStart + lineCount);
});

afterEach(destroyGraphDiv);
afterEach(function(done) {
var gd = d3.select('.js-plotly-plot').node();
if(gd) Plotly.purge(gd);
destroyGraphDiv();

return delay(50)().then(done);
});

describe('edge cases', function() {

Expand Down Expand Up @@ -496,7 +502,7 @@ describe('@gl parcoords', function() {
.then(done);
});

it('@flaky Skip dimensions which are not plain objects or whose `values` is not an array', function(done) {
it('Skip dimensions which are not plain objects or whose `values` is not an array', function(done) {

var mockCopy = Lib.extendDeep({}, mock1);
var newDimension, i, j;
Expand Down
0