8000 Optimize performance of setCategoryIndex by hy9be · Pull Request #1544 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Optimize performance of setCategoryIndex #1544

New 8000 issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 10, 2017
Merged

Optimize performance of setCategoryIndex #1544

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
40e69d3
Optimize performance of setCategoryIndex
hy9be Mar 31, 2017
b47c7af
Update unit test
hy9be Mar 31, 2017
e8941d6
Refactor the changes
hy9be Apr 3, 2017
b3fb03d
Build the lookup map for initialized categories
hy9be Apr 3, 2017
2992126
Reset the lookup map when the categories are reset
hy9be Apr 3, 2017
989f07a
Optimize the scatter trace sorting comparator with map
hy9be Apr 5, 2017
91cfaa4
Merge remote-tracking branch 'origin/master' into perf-setcategoryindex
hy9be Apr 8, 2017
abcd729
Clean ESLint errors in CI
hy9be Apr 8, 2017
153f547
getCategoryIndex falls back to the former implementation to fix the f…
hy9be Apr 8, 2017
ff043b4
Fix another problem in getCategoryIndex
hy9be Apr 8, 2017
c32163e
Add comments
hy9be Apr 8, 2017
d2be6c9
Remove the fallback to indexOf search in getCategoryIndex, update the…
hy9be Apr 10, 2017
14d6649
Remove out of date comments
hy9be Apr 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize the scatter trace sorting comparator with map 
Construct a map rather than an array to improve the performance of index search. Jasmine tests passed.
  • Loading branch information
@hy9be
hy9be authored Apr 5, 2017
commit 989f07a67091733f9b1621de48fee6ea6660142c
8 changes: 4 additions & 4 deletions src/traces/scatter/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ module.exports = function plot(gd, plotinfo, cdscatter, transitionOpts, makeOnCo
// Sort the traces, once created, so that the ordering is preserved even when traces
// are shown and hidden. This is needed since we're not just wiping everything out
// and recreating on every update.
for(i = 0, uids = []; i < cdscatter.length; i++) {
uids[i] = cdscatter[i][0].trace.uid;
for(i = 0, uids = {}; i < cdscatter.length; i++) {
uids[cdscatter[i][0].trace.uid] = i;
}

scatterlayer.selectAll('g.trace').sort(function(a, b) {
var idx1 = uids.indexOf(a[0].trace.uid);
var idx2 = uids.indexOf(b[0].trace.uid);
var idx1 = uids[a[0].trace.uid];
var idx2 = uids[b[0].trace.uid];
return idx1 > idx2 ? 1 : -1;
});

Expand Down
0