8000 3D hover labels don't show up with `mouse-change@1.4.0` · Issue #1268 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content
8000

3D hover labels don't show up with mouse-change@1.4.0 #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000 Closed
etpinard opened this issue Dec 22, 2016 · 2 comments · Fixed by #1305
Closed

3D hover labels don't show up with mouse-change@1.4.0 #1268

etpinard opened this issue Dec 22, 2016 · 2 comments · Fixed by #1305
Assignees
@etpinard
Labels
bug something broken
Milestone
v1.22.0

Comments

@etpinard
Copy link
Contributor
etpinard commented Dec 22, 2016 •
edited
Loading

that is 3D hover labels are broken in bundles built from a fresh npm i --- fixed in v1.21.3

Commit mikolalysenko/mouse-change@2aba950 and more precisely this line ensured that mouse change listeners could be detached. Unfortunately, our gl3d scene code relied on the old (mouse-change@1.3.0) buggy behavior here.

Removing that above line

 scene.glplot.mouseListener.enabled = false;

in plots/gl3d/scene.js appears to solve the issue. But, I afraid that it might lead to side-effects such as memory leaks. We should look into this in depth before merging a patch.
@etpinard etpinard added the bug something broken label Dec 22, 2016
@etpinard
Copy link
Contributor Author

cc @dfcreative @alexcjohnson

@etpinard etpinard added this to the v1.22.0 milestone Jan 4, 2017
@etpinard etpinard mentioned this issue Jan 4, 2017
Merged
@etpinard etpinard self-assigned this Jan 6, 2017
@rreusser
Copy link
Contributor
rreusser commented Jan 16, 2017 •
edited
Loading

Am I correct in understanding that plotly simply doesn't use mouseListener.enabled = true anywhere? Or if that command was broken, perhaps it does use it even though it requests not to. At least I'm not immediately able to find a reference to where it is used. It sounds like that might indeed leak a bit of memory then if listeners are reattached but never detached. Perhaps they only leak on initializeGLPlot? That doesn't sound horrible.

This is a bit confusing.

@etpinard etpinard mentioned this issue Jan 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging a pull request may close this issue.

bump mouse-change dep to ^1.4.0 plotly/plotly.js
2 participants
@rreusser @etpinard
0