8000 show labels for light and dark styles similar to mapbox · plotly/plotly.js@6a46b43 · GitHub
[go: up one dir, main page]

Skip to content

Commit 6a46b43

Browse files
committed
show labels for light and dark styles similar to mapbox
1 parent 5e3d3fe commit 6a46b43

13 files changed

+3
-8
lines changed

src/plots/map/constants.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ var stylesMap = {
130130
basic: cartoVoyager,
131131
streets: cartoVoyager,
132132
outdoors: cartoVoyager,
133-
light: cartoPositronNoLabels,
134-
dark: cartoDarkmatterNoLabels,
133+
light: cartoPositron,
134+
dark: cartoDarkmatter,
135135
satellite: arcgisSat,
136136
'satellite-streets': arcgisSatHybrid,
137137
'open-street-map': {

test/image/baselines/map_0.png

10.4 KB
Loading
24.7 KB
Loading

test/image/baselines/map_bubbles.png

13 KB
Loading
21.9 KB
Loading
Loading
7.78 KB
Loading
Loading
180 Bytes
Loading

test/image/baselines/map_layers.png

4.53 KB
Loading
5 Bytes
Loading
8.02 KB
Loading

test/jasmine/tests/map_test.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -514,12 +514,7 @@ describe('map plots', function() {
514514
expect(mapInfo.style.name).toEqual(style);
515515
}
516516

517-
// TODO
518-
// this one now logs:
519-
// 'Unable to perform style diff: Unimplemented: setSprite.. Rebuilding the style from scratch.'
520-
// https://github.com/mapbox/mapbox-gl-js/issues/6933
521-
522-
assertLayout('Dark Matter without labels');
517+
assertLayout('Dark Matter');
523518

524519
Plotly.relayout(gd, 'map.style', 'carto-positron')
525520
.then(function() {

0 commit comments

Comments
 (0)
0