Add comment to explain else case

marthacryan · marthacryan · commit 5f128bbe7b36 · 2024-11-25T17:05:37.000-06:00
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -2831,6 +2831,9 @@ function diffLayout(gd, oldFullLayout, newFullLayout, immutable, transition) {
                 // what you're asking for HAS changed, so clear _inputDomain and let us start from scratch
                 newFullLayout[key]._inputDomain = null;
             }
+            // We skip the else case (newDomain !== oldInputDomain && newDomain === oldDomain)
+            // because it's likely that if the newDomain and oldDomain are the same, the user
+            // passed in the same layout object and we should keep the _inputDomain.
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2831,6 +2831,9 @@ function diffLayout(gd, oldFullLayout, newFullLayout, immutable, transition) {`
`2831`	`2831`	`// what you're asking for HAS changed, so clear _inputDomain and let us start from scratch`
`2832`	`2832`	`newFullLayout[key]._inputDomain = null;`
`2833`	`2833`	`}`
	`2834`	`+ // We skip the else case (newDomain !== oldInputDomain && newDomain === oldDomain)`
	`2835`	`+ // because it's likely that if the newDomain and oldDomain are the same, the user`
	`2836`	`+ // passed in the same layout object and we should keep the _inputDomain.`
`2834`	`2837`	`}`
`2835`	`2838`	`}`
`2836`	`2839`