mojtaba-proof logic

etpinard · etpinard · commit 5427dc047bb3 · 2019-10-22T14:56:38.000-04:00
diff --git a/src/plots/mapbox/mapbox.js b/src/plots/mapbox/mapbox.js
@@ -315,14 +315,16 @@ proto.updateData = function(calcData) {
         trace = calcTrace[0].trace;
         traceObj = traceHash[trace.uid];
 
+        var didUpdate = false;
         if(traceObj) {
             if(traceObj.type === trace.type) {
                 traceObj.update(calcTrace);
+                didUpdate = true;
             } else {
                 traceObj.dispose();
-                traceHash[trace.uid] = trace._module.plot(this, calcTrace);
             }
-        } else if(trace._module) {
+        }
+        if(!didUpdate && trace._module) {
             traceHash[trace.uid] = trace._module.plot(this, calcTrace);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -315,14 +315,16 @@ proto.updateData = function(calcData) {`
`315`	`315`	`trace = calcTrace[0].trace;`
`316`	`316`	`traceObj = traceHash[trace.uid];`
`317`	`317`
	`318`	`+ var didUpdate = false;`
`318`	`319`	`if(traceObj) {`
`319`	`320`	`if(traceObj.type === trace.type) {`
`320`	`321`	`traceObj.update(calcTrace);`
	`322`	`+ didUpdate = true;`
`321`	`323`	`} else {`
`322`	`324`	`traceObj.dispose();`
`323`		`- traceHash[trace.uid] = trace._module.plot(this, calcTrace);`
`324`	`325`	`}`
`325`		`- } else if(trace._module) {`
	`326`	`+ }`
	`327`	`+ if(!didUpdate && trace._module) {`
`326`	`328`	`traceHash[trace.uid] = trace._module.plot(this, calcTrace);`
`327`	`329`	`}`
`328`	`330`	`}`