Follow up to #1936: hash the selectize id so it can be used as an HTML id

cpsievert · cpsievert · commit e02a704d3743 · 2021-04-15T15:08:35.000-05:00
Fixes this reprex https://github.com/ropensci/plotly/pull/1936\#issuecomment-820616142
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -42,7 +42,7 @@ Imports:
     vctrs,
     tibble,
     lazyeval (>= 0.2.0),
-    rlang,
+    rlang (>= 0.4.10),
     crosstalk,
     purrr,
     data.table,
diff --git a/R/utils.R b/R/utils.R
@@ -379,7 +379,9 @@ supply_highlight_attrs <- function(p) {
 
     # include one selectize dropdown per "valid" SharedData layer
     if (isTRUE(p$x$highlight$selectize)) {
-      p$x$selectize[[i]] <- list(
+      # Hash i (the crosstalk group id) so that it can be used
+      # as an HTML id client-side (i.e., key shouldn't contain spaces)
+      p$x$selectize[[rlang::hash(i)]] <- list(
         items = data.frame(value = k, label = k), group = i
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,9 @@ supply_highlight_attrs <- function(p) {`
`379`	`379`
`380`	`380`	`# include one selectize dropdown per "valid" SharedData layer`
`381`	`381`	`if (isTRUE(p$x$highlight$selectize)) {`
`382`		`- p$x$selectize[[i]] <- list(`
	`382`	`+ # Hash i (the crosstalk group id) so that it can be used`
	`383`	`+ # as an HTML id client-side (i.e., key shouldn't contain spaces)`
	`384`	`+ p$x$selectize[[rlang::hash(i)]] <- list(`
`383`	`385`	`items = data.frame(value = k, label = k), group = i`
`384`	`386`	`)`
`385`	`387`	`}`