8000 Add Julia test workflow by etpinard · Pull Request #176 · plotly/Dash.jl · GitHub
[go: up one dir, main page]
Skip to content

Add Julia test workflow#176

Merged
etpinard merged 5 commits intodevfrom
jl_test-worfflow
Jan 27, 2023
Merged

Add Julia test workflow#176
etpinard merged 5 commits intodevfrom
jl_test-worfflow

Conversation

@etpinard
Copy link
Collaborator
@etpinard etpinard commented Nov 28, 2022

As discussed in #175 (comment), I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛

I'm thinking we could also drop these lines:

Dash.jl/.circleci/config.yml

Lines 30 to 33 in f0606e0

- run:
name: 🔎 Unit tests
command: |
julia test/ci_prepare.jl

Dash.jl/test/ci_prepare.jl

Line 11 in f0606e0

Pkg.test("Dash", coverage=true)

and have the CircleCI workflow be used just for the integration (percy) tests.

@etpinard
add jl_test workflow
03e57e0 
to run the Julia `] test`
on multiple Julia versions.
@etpinard
bump lowest julia version tested to 1.4
c2d4aca 
to match PlotlyBase compat
@github-actions github-actions bot added the CI label Nov 28, 2022
etpinard
etpinard commented Nov 28, 2022
View reviewed changes
.github/workflows/jl_test.yml Outdated
fail-fast: false
matrix:
jl_version: ["1.3", "1.6", "1.8"]
jl_version: ["1.4", "1.6", "1.8"]
Copy link
Collaborator Author
@etpinard etpinard Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on Julia 1.3 leads to

image

We should probably update

Dash.jl/Project.toml

Line 39 in f0606e0

julia = "1.3"

to match the PlotlyBase.jl compat

@etpinard
Copy link
Collaborator Author
etpinard commented Nov 28, 2022

Hmm, I'll need to figure out why the final step of the CircleCI workflow is failing

image

@mind6
Copy link
Contributor
mind6 commented Dec 3, 2022

As discussed in #175 (comment), I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛

I'm thinking we could also drop these lines:

Dash.jl/.circleci/config.yml

Lines 30 to 33 in f0606e0

- run:
name: 🔎 Unit tests
command: |
julia test/ci_prepare.jl

Dash.jl/test/ci_prepare.jl

Line 11 in f0606e0

Pkg.test("Dash", coverage=true)

and have the CircleCI workflow be used just for the integration (percy) tests.

The github actions seem quite nice. Don't know anything about CircleCI/percy hope it works out.

@etpinard etpinard mentioned this pull request Jan 9, 2023
Closed
@etpinard etpinard mentioned this pull request Jan 23, 2023
Closed
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 27, 2023
@etpinard
Copy link
Collaborator Author
etpinard commented Jan 27, 2023

We have passing tests 🎉 - merging!

@etpinard etpinard merged commit 754ff49 into dev Jan 27, 2023
@etpinard etpinard deleted the jl_test-worfflow branch January 27, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard @mind6
0