8000 rewrite websocket code to avoid deprecated pekko-http code (and switch to the maintained code) · Issue #13744 · playframework/playframework · GitHub
[go: up one dir, main page]

Skip to content

rewrite websocket code to avoid deprecated pekko-http code (and switch to the maintained code) #13744

@pjfanning

Description

@pjfanning
  • UpgradeToWebSocket is deprecated (for years) and will be removed in pekko-http 2.0.0
  • The supported websocket code in pekko-http is based on request.attribute(AttributeKeys.websocketUpgrade) and this returns a WebSocketUpgrade instance
  • The handleMessages on WebSocketUpgrade expects a Flow that works with pekko-http ws.Message classes. These ws.Message definitions are similar to the Play WebSocket Message instances.
  • We probably need to convert the Play Flow that works with Play Messages to a Flow that works with pekko-http ws.Message instances so that we can use WebSocketUpgrade.handleMessages.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0