Pass boolean literal args as named arg in generated routes files

mkurz · mkurz · commit 4cdd012a0836 · 2024-02-27T00:34:19.000+01:00
Fixes scala/scala#10612 (cherry picked from commit a1ca2b3)
diff --git a/dev-mode/play-routes-compiler/src/main/scala/play/routes/compiler/RoutesModels.scala b/dev-mode/play-routes-compiler/src/main/scala/play/routes/compiler/RoutesModels.scala
@@ -126,7 +126,8 @@ trait PathPart
  * @param encode Whether this part should be encoded or not.
  */
 case class DynamicPart(name: String, constraint: String, encode: Boolean) extends PathPart with Positional {
-  override def toString = """DynamicPart("""" + name + "\", \"\"\"" + constraint + "\"\"\"," + encode + ")" // "
+  override def toString =
+    """DynamicPart("""" + name + "\", \"\"\"" + constraint + "\"\"\", encodeable=" + encode + ")" // "
 }
 
 /**
diff --git a/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-routes-compilation/tests/RouterSpec.scala b/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/routes-compiler-routes-compilation/tests/RouterSpec.scala
@@ -102,7 +102,7 @@ object RouterSpec extends PlaySpecification {
       whenNoValue: Future[play.api.mvc.Result] => Any,
       whenNoParam: Future[play.api.mvc.Result] => Any
   ) =
-    testQueryParamBinding(paramType, path, successParams, expectationSuccess, whenNoValue, whenNoParam, true)
+    testQueryParamBinding(paramType, path, successParams, expectationSuccess, whenNoValue, whenNoParam, withDefault = true)
 
   private def testQueryParamBinding(
       paramType: String,

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,8 @@ trait PathPart`
`126`	`126`	`* @param encode Whether this part should be encoded or not.`
`127`	`127`	`*/`
`128`	`128`	`case class DynamicPart(name: String, constraint: String, encode: Boolean) extends PathPart with Positional {`
`129`		`- override def toString = """DynamicPart("""" + name + "\", \"\"\"" + constraint + "\"\"\"," + encode + ")" // "`
	`129`	`+ override def toString =`
	`130`	`+ """DynamicPart("""" + name + "\", \"\"\"" + constraint + "\"\"\", encodeable=" + encode + ")" // "`
`130`	`131`	`}`
`131`	`132`
`132`	`133`	`/**`