[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get group pagination does not paginate anymore #79

Open
plankes-projects opened this issue Sep 25, 2020 · 1 comment
Open

get group pagination does not paginate anymore #79

plankes-projects opened this issue Sep 25, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects

Comments

@plankes-projects
Copy link
Owner
plankes-projects commented Sep 25, 2020

GroupObjectDao::paginateGroups

Removed paginate because we now order groups by last_activity_date and not by id. This breaks old paginate implementation.
Update the query such it works again.

we have a list of groups order by actvity (for user 1):
id -> group name
4 -> group 4
3 -> group 3
1 -> group 1
2 -> group 2

paginateGroups(user: 1, limit: 2, lastId: null) shall return:
4 -> group 4
3 -> group 3

paginateGroups(user: 1, limit: 2, lastId: 3) shall return:
1 -> group 1
2 -> group 2

@plankes-projects plankes-projects changed the title get group pagination does not pageinate get group pagination does not paginate anymore Sep 25, 2020
@plankes-projects plankes-projects added the bug Something isn't working label Sep 25, 2020
@plankes-projects plankes-projects added this to To do in Development via automation Sep 25, 2020
@plankes-projects plankes-projects added the good first issue Good for newcomers label Sep 25, 2020
@plankes-projects
Copy link
Owner Author

Current client uses a limit of 50. This means we will most likely not hit the pagination functionality. Thus this bug does not have prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development
  
To do
Development

No branches or pull requests

1 participant