pythongh-126341: add release check to __iter__ method of memoryview (python#126759)

ritvikpasham · blurb-it[bot] · ZeroIntensity · picnixz · commit 0c6ec4ac6bdf · 2024-11-19T12:04:50.000+01:00
Co-authored-by: blurb-it[bot] &lt;43283697+blurb-it[bot]@users.noreply.github.com&gt;
Co-authored-by: Peter Bierma &lt;zintensitydev@gmail.com&gt;
Co-authored-by: Victor Stinner &lt;vstinner@python.org&gt;
Co-authored-by: sobolevn &lt;mail@sobolevn.me&gt;
diff --git a/Lib/test/test_buffer.py b/Lib/test/test_buffer.py
@@ -3910,6 +3910,8 @@ def test_memoryview_check_released(self):
         self.assertRaises(ValueError, memoryview, m)
         # memoryview.cast()
         self.assertRaises(ValueError, m.cast, 'c')
+        # memoryview.__iter__()
+        self.assertRaises(ValueError, m.__iter__)
         # getbuffer()
         self.assertRaises(ValueError, ndarray, m)
         # memoryview.tolist()
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issue-126341.5SdAe1.rst b/Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issue-126341.5SdAe1.rst
@@ -0,0 +1 @@
+Now :exc:`ValueError` is raised instead of :exc:`SystemError` when trying to iterate over a released :class:`memoryview` object.
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
@@ -3356,6 +3356,7 @@ memory_iter(PyObject *seq)
         PyErr_BadInternalCall();
         return NULL;
     }
+    CHECK_RELEASED(seq);
     PyMemoryViewObject *obj = (PyMemoryViewObject *)seq;
     int ndims = obj->view.ndim;
     if (ndims == 0) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Now :exc:`ValueError` is raised instead of :exc:`SystemError` when trying to iterate over a released :class:`memoryview` object.
Original file line number	Diff line number	Diff line change
`@@ -3356,6 +3356,7 @@ memory_iter(PyObject *seq)`
`3356`	`3356`	`PyErr_BadInternalCall();`
`3357`	`3357`	`return NULL;`
`3358`	`3358`	`}`
	`3359`	`+ CHECK_RELEASED(seq);`
`3359`	`3360`	`PyMemoryViewObject obj = (PyMemoryViewObject )seq;`
`3360`	`3361`	`int ndims = obj->view.ndim;`
`3361`	`3362`	`if (ndims == 0) {`