8000 fix: Remove overwrite composeurl · phthhieu/sentry-javascript@f5a5880 · GitHub
[go: up one dir, main page]

8000 Skip to content

Commit f5a5880

Browse files
committed
fix: Remove overwrite composeurl
1 parent 0f642a0 commit f5a5880

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed
Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
1-
import { DSNComponents } from '@sentry/types';
21
import { expect } from 'chai';
32
import { BaseTransport } from '../../src/transports/base';
43

54
const testDSN = 'https://123@sentry.io/42';
65

76
class SimpleTransport extends BaseTransport {}
8-
// tslint:disable-next-line:max-classes-per-file
9-
class ComplexTransport extends BaseTransport {
10-
public composeUrl(dsn: DSNComponents): string {
11-
return `https://${dsn.host}/${dsn.user}`;
12-
}
13-
}
147

158
describe('BaseTransport', () => {
169
it('doesnt provide send() implementation', async () => {
@@ -23,13 +16,8 @@ describe('BaseTransport', () => {
2316
}
2417
});
2518

26-
it('provides composeEndpointUrl() implementation', () => {
19+
it('has correct endpoint url', () => {
2720
const transport = new SimpleTransport({ dsn: testDSN });
2821
expect(transport.url).equal('https://sentry.io/api/42/store/?sentry_key=123&sentry_version=7');
2922
});
30-
31-
it('allows overriding composeEndpointUrl() implementation', () => {
32-
const transport = new ComplexTransport({ dsn: testDSN });
33-
expect(transport.url).equal('https://sentry.io/123');
34-
});
3523
});

0 commit comments

Comments
 (0)
0