fix: Make sure that getSession exists before calling it (getsentry#3017)

kamilogorek · web-flow · commit bd6028a9f0cf · 2020-10-29T15:53:44.000+01:00
diff --git a/packages/core/src/baseclient.ts b/packages/core/src/baseclient.ts
@@ -522,7 +522,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
           throw new SentryError('`beforeSend` returned `null`, will not send event.');
         }
 
-        const session = scope && scope.getSession();
+        const session = scope && scope.getSession && scope.getSession();
         if (!isTransaction && session) {
           this._updateSessionFromEvent(session, processedEvent);
         }
diff --git a/packages/hub/src/hub.ts b/packages/hub/src/hub.ts
@@ -384,7 +384,7 @@ export class Hub implements HubInterface {
     const { scope, client } = this.getStackTop();
     if (!scope) return;
 
-    const session = scope.getSession();
+    const session = scope.getSession && scope.getSession();
     if (session) {
       session.close();
       if (client && client.captureSession) {

Original file line number	Diff line number	Diff line change
`@@ -522,7 +522,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement`
`522`	`522`	throw new SentryError('`beforeSend` returned `null`, will not send event.');
`523`	`523`	`}`
`524`	`524`
`525`		`- const session = scope && scope.getSession();`
	`525`	`+ const session = scope && scope.getSession && scope.getSession();`
`526`	`526`	`if (!isTransaction && session) {`
`527`	`527`	`this._updateSessionFromEvent(session, processedEvent);`
`528`	`528`	`}`