[Finder] Avoid unnecessary use of the @ operator

Seldaek · Seldaek · commit f3408ccf2cea · 2012-04-08T19:39:04.000+02:00
diff --git a/src/Symfony/Component/Finder/Comparator/DateComparator.php b/src/Symfony/Component/Finder/Comparator/DateComparator.php
@@ -32,7 +32,10 @@ public function __construct($test)
             throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a date test.', $test));
         }
 
-        if (false === $target = @strtotime($matches[2])) {
+        try {
+            $date = new \DateTime($matches[2]);
+            $target = $date->format('U');
+        } catch (\Exception $e) {
             throw new \InvalidArgumentException(sprintf('"%s" is not a valid date.', $matches[2]));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,10 @@ public function __construct($test)`
`32`	`32`	`throw new \InvalidArgumentException(sprintf('Don\'t understand "%s" as a date test.', $test));`
`33`	`33`	`}`
`34`	`34`
`35`		`- if (false === $target = @strtotime($matches[2])) {`
	`35`	`+ try {`
	`36`	`+ $date = new \DateTime($matches[2]);`
	`37`	`+ $target = $date->format('U');`
	`38`	`+ } catch (\Exception $e) {`
`36`	`39`	`throw new \InvalidArgumentException(sprintf('"%s" is not a valid date.', $matches[2]));`
`37`	`40`	`}`
`38`	`41`