8000 VC14 fixes (2) and a test fix by Jan-E · Pull Request #660 · phpredis/phpredis · GitHub
[go: up one dir, main page]

Skip to content

VC14 fixes (2) and a test fix #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2015
Merged

VC14 fixes (2) and a test fix #660

merged 3 commits into from
Oct 2, 2015

Conversation

Jan-E
Copy link
Contributor
@Jan-E Jan-E commented Sep 17, 2015

Two fixes for VC14. The test fix is generic and should be applied to the other branches as well.

@michael-grunder
Copy link
Member

@Jan-E Do you have an email address I can get you at? If you don't want to post it here, feel free to email me, which is on my account and in the source files :)

@Jerry-Shaw
Copy link

New update comments?

@Jan-E
Copy link
Contributor Author
Jan-E commented Sep 17, 2015

phpdev@ehrhardt.nl

@Jan-E
Copy link
Contributor Author
Jan-E commented Sep 17, 2015

@Jerry-Shaw nothing essential, mostly cleanup. The php7 branch is as good as the branch for php5 before and after these commits.

@Jerry-Shaw
Copy link

Haha, if there are new ones, I'm glad to test again.

@Jan-E
Copy link
Contributor Author
Jan-E commented Sep 17, 2015

Not really needed. I already compiled PHP7 RC3 with this branch:
https://www.apachelounge.com/viewtopic.php?t=6617

@Jerry-Shaw
Copy link

Wow, that is good. I can use yours. Thanks so much, haha..

Just ready to get PHP7 RC3 now.

@Jan-E
Copy link
Contributor Author
Jan-E commented Sep 24, 2015

@michael-grunder Ping. Friendly reminder.

michael-grunder added a commit that referenced this pull request Oct 2, 2015
VC14 fixes (2) and a test fix
@michael-grunder michael-grunder merged commit ea98401 into phpredis:php7 Oct 2, 2015
@michael-grunder
Copy link
Member

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0