VC14 fixes (2) and a test fix #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jan-E Do you have an email address I can get you at? If you don't want to post it here, feel free to email me, which is on my account and in the source files :) |
|
New update comments? |
|
@Jerry-Shaw nothing essential, mostly cleanup. The php7 branch is as good as the branch for php5 before and after these commits. |
|
Haha, if there are new ones, I'm glad to test again. |
|
Not really needed. I already compiled PHP7 RC3 with this branch: |
|
Wow, that is good. I can use yours. Thanks so much, haha.. Just ready to get PHP7 RC3 now. |
|
@michael-grunder Ping. Friendly reminder. |
michael-grunder
added a commit
that referenced
this pull request
Oct 2, 2015
VC14 fixes (2) and a test fix
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for VC14. The test fix is generic and should be applied to the other branches as well.