Future of the open source project (phpredis vs Relay) #2633
-
|
Hi guys I just noticed that both main contributors for phpredis are working for Cachewerk. Given that Cachewerk's main business is a commercial competitor to phpredis, could we get some clarification on the future of this extension? I wish you much success with Relay but I and many other app developers won't ever use a non open-source PHP extension. There are many core commands and features from Redis 7 and 8 that haven't been added to phpredis yet. It seems keeping command-parity with current Redis versions stalled in late 2022. Eg: I totally understand that open source development is a "when time permits" kind of thing and I appreciate the efforts you've put into maintaining this project. But it'd be good to get some clarification on the potential conflict of interest and if the goal is still to keep adding new Redis versions' commands to phpredis and continue improving the extension's performance. For example - I see Relay has JSON support and I'm guessing(?) it would have been fairly simple to add it to phpredis at the same time. Instead I saw this reply suggesting using Relay instead, which is concerning: #2617 (comment). RedisJSON and Redis Stack are free for commercial use under the RSAL (you just can't resell it as service): https://redis.io/blog/introducing-redis-stack/. Therefor JSON commands really shouldn't be excluded from this extension. Cheers |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 4 replies
-
They are not excluded, and we'd never take such a stance. As you mentioned PhpRedis is open source, if you need the JSON command methods now why don't you contribute and open a pull request instead of jumping to strange conclusions? If you can't, but want feature parity with Redis, there is also Predis which is officially endorsed by Redis Inc. Their employees are contributing to it, so it will always support the latest Redis commands on release day. |
Beta Was this translation helpful? Give feedback.
-
|
Because phpredis is orders of magnitude faster than predis since it’s a C extension: https://akalongman.medium.com/phpredis-vs-predis-comparison-on-real-production-data-a819b48cbadb |
Beta Was this translation helpful? Give feedback.
-
|
In that case you I'd suggest learning C and start to contribute. |
Beta Was this translation helpful? Give feedback.
-
I was searching for info on JSON commands and found this: #2617 (comment). The reply said they weren't supported and suggested Relay as an alternative. It gave me the impression that there were no plans to add them to phpredis. Then I saw the pinned "Redis 7.0 support" issue from 2022 was still open: #2068 And that both main contributors work for the makers of Relay: https://github.com/phpredis/phpredis/graphs/contributors So instead of jumping to "strange conclusions" I asked for clarification and tried my best to be polite. Michael was kind enough to answer, which I really appreciated. I don't think it was an unreasonable question and implying people can't ask questions like this unless they are contributors isn't really in the spirit of open source. |
Beta Was this translation helpful? Give feedback.
-
Plans for PhpRedis haven't changed. We're going to keep updating it as the (now several) Redis-compatible servers are updated themselves adding commands and command options as they come.
Almost all of these are implemented, especially the major new features and/or command arguments. We will implement Redis 8 is still in prerelease. We'll implement these commands once it's released. According to their blog post, they're adding "JSON, time series, and five probabilistic types". We'll add them all to phpredis over time.
Yes
This is an external module until Redis 8.0 is released. We've never added any module-specific commands to phpredis. Now that they'll be in vanilla Redis we will.
It wasn't what licence Redis Stack had/has it was that it wasn't vanilla Redis. We've also been adding new Valkey features like SET IFEQ |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for clarifying Michael, much appreciated. Thats’s reassuring to hear. |
Beta Was this translation helpful? Give feedback.
Plans for PhpRedis haven't changed. We're going to keep updating it as the (now several) Redis-compatible servers are updated themselves adding commands and command options as they come.