8000 Test aginst the first stable version of valkey. · phpredis/phpredis@f350dc3 · GitHub
[go: up one dir, main page]

Skip to content

Commit f350dc3

Browse files
Test aginst the first stable version of valkey.
Now that valkey has an official release we can test against that and remove the "continue-on-error" flag in CI.
1 parent 3d7be35 commit f350dc3

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ jobs:
121121
- name: Install ValKey
122122
if: matrix.server == 'valkey'
123123
run: |
124-
git clone https://github.com/valkey-io/valkey.git
124+
git clone --depth 1 --branch 7.2.5 https://github.com/valkey-io/valkey.git
125125
cd valkey && BUILD_TLS=yes sudo make install
126126
127127
- name: Build phpredis
@@ -173,7 +173,6 @@ jobs:
173173
done
174174
175175
- name: Start ${{ matrix.server }} sentinel
176-
continue-on-error: ${{ matrix.server == 'valkey' }}
177176
run: |
178177
wget raw.githubusercontent.com/redis/redis/7.0/sentinel.conf
179178
for PORT in {26379..26380}; do
@@ -205,7 +204,6 @@ jobs:
205204
--cluster-replicas 1 --user phpredis -a phpredis
206205
207206
- name: Run tests
208-
continue-on-error: ${{ matrix.server == 'valkey' }}
209207
run: |
210208
php tests/TestRedis.php --class Redis --user phpredis --auth phpredis
211209
php tests/TestRedis.php --class RedisArray --user phpredis --auth phpredis

0 commit comments

Comments
 (0)
0