We don't need to use a ranom value for our ECHO liveness challenge.

michael-grunder · michael-grunder · commit c139de3abac1 · 2024-06-01T13:41:26.000-07:00
A microsecond resolution timestamp combined with a monotonically
incremented counter should be sufficient.

This also fixes PHP 8.4 compilation as PHP 8.4 doesn't seem to have
`php_rand()`.
diff --git a/library.c b/library.c
@@ -2886,11 +2886,13 @@ redis_sock_create(char *host, int host_len, int port,
 }
 
 static int redis_uniqid(char *buf, size_t buflen) {
+    static unsigned long counter = 0;
     struct timeval tv;
+
     gettimeofday(&tv, NULL);
 
     return snprintf(buf, buflen, "phpredis:%08lx%05lx:%08lx",
-                    (long)tv.tv_sec, (long)tv.tv_usec, (long)php_rand());
+                    (long)tv.tv_sec, (long)tv.tv_usec, counter++);
 }
 
 static int redis_stream_liveness_check(php_stream *stream) {

Original file line number	Diff line number	Diff line change
`@@ -2886,11 +2886,13 @@ redis_sock_create(char *host, int host_len, int port,`
`2886`	`2886`	`}`
`2887`	`2887`
`2888`	`2888`	`static int redis_uniqid(char *buf, size_t buflen) {`
	`2889`	`+ static unsigned long counter = 0;`
`2889`	`2890`	`struct timeval tv;`
	`2891`	`+`
`2890`	`2892`	`gettimeofday(&tv, NULL);`
`2891`	`2893`
`2892`	`2894`	`return snprintf(buf, buflen, "phpredis:%08lx%05lx:%08lx",`
`2893`		`- (long)tv.tv_sec, (long)tv.tv_usec, (long)php_rand());`
	`2895`	`+ (long)tv.tv_sec, (long)tv.tv_usec, counter++);`
`2894`	`2896`	`}`
`2895`	`2897`
`2896`	`2898`	`static int redis_stream_liveness_check(php_stream *stream) {`