Remove special time test

michael-grunder · michael-grunder · commit 8c864a5c5012 · 2025-05-07T13:26:31.000-07:00
diff --git a/tests/RedisClusterTest.php b/tests/RedisClusterTest.php
@@ -314,41 +314,6 @@ public function testTime() {
         $this->assertEquals(strval(intval($usec)), strval($usec));
     }
 
-    /* This is a hack to try and fix a consistently flaky test on GitHub CI
-     * runners. My only guess is that `TIME` requires a syscall, which might
-     * stall Redis on these VMs long enough to cause a timeout. */
-    //public function testTimeGitHubCI() {
-    //    for ($i = 0; $i < 5; $i++)
-    //        printf("here\n");
-
-    //    if (getenv('GITHUB_ACTIONS') !== 'true')
-    //        $this->markTestSkipped();
-
-    //    // VM stall?
-    //    if (function_exists('hrtime')) {
-    //        hrtime(true);
-    //    } else {
-    //        microtime(true);
-    //    }
-
-    //    for ($i = 0; $i < 10; $i++) {
-    //        try {
-    //            [$sec, $usec] = $this->redis->time(uniqid());
-    //            $this->assertEquals(strval(intval($sec)), strval($sec));
-    //            $this->assertEquals(strval(intval($usec)), strval($usec));
-    //        } catch (Exception $ex) {
-    //            printf("exception: %s\n", $ex->getMessage());
-    //            foreach ([7000, 7001, 7002] as $port) {
-    //                $st = microtime(true);
-    //                $time = shell_exec("redis-cli --user phpredis -a phpredis -p $port TIME");
-    //                $et = microtime(true);
-    //                printf("TIME[%d]: %s (%.3f sec)\n", $port,
-    //                       json_encode($time), $et - $st);
-    //            }
-    //        }
-    //    }
-    //}
-
     public function testScan() {
         $key_count = 0;
         $scan_count = 0;
