Add test for MethodNode::isDeclaration()
#1194
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if there is any init process or something else I might be missing? I suspect that the related ASTs for the |
|
i would try targeting 3.x instead, things are simpler, cleaner and you get full phpstan checks on your changes. |
I'll try to create a new PR against 3.x, thanks for pointing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug report
Issue: n/a
Breaking change: no (at least, not yet)
IIUC,
MethodNode::isDeclaration()is not working as expected, because methods overriding or implementing parent classes or interfaces are being interpreted as declarations.The added test tries to expose the described issue.