10000 [ticket/14670] Use symfony 3.x in master branch by marc1706 · Pull Request #4350 · phpbb/phpbb · GitHub
[go: up one dir, main page]

Skip to content

[ticket/14670] Use symfony 3.x in master branch #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2016

Conversation

marc1706
Copy link
Member
@marc1706 marc1706 commented Jun 11, 2016

Checklist:

  • Correct branch: master for new features; 3.2.x, 3.1.x for fixes
  • Tests pass
  • Code follows coding guidelines: master / 3.2.x, 3.1.x
  • Commit follows commit message format

https://tracker.phpbb.com/browse/PHPBB3-14670

@marc1706 marc1706 added this to the 3.3.0-a1 milestone Jun 11, 2016
@@ -25,41 +25,40 @@
"phpbb/phpbb-core": "self.version"
},
"require": {
"php": ">=5.4,<7.1",
"php": ">=5.4",
Copy link
Member
@Crizz0 Crizz0 Jun 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony 3.1 needs PHP 5.5.9

@marc1706
Copy link
Member Author

I just pushed this to have tests running. This will need a few more fixes probably.

@marc1706 marc1706 changed the title [ticket/14670] Use symfony 3.x in master brancher [ticket/14670] Use symfony 3.x in master branche Jun 19, 2016
@marc1706 marc1706 changed the title [ticket/14670] Use symfony 3.x in master branche [ticket/14670] Use symfony 3.x in master branch Jun 20, 2016
@Nicofuma
Copy link
Member

another BC break to take in account: symfony/symfony#19114

@marc1706
Copy link
Member Author

Ok. We should start a page of BC breaks in symfony so we don't loose track of this. I also still need to figure out what happened to the stupid UI tests.

@nicolas-grekas
Copy link
Contributor

@Nicofuma can you please explain how the PR you linked is affecting you?

@marc1706
Copy link
Member Author

@VSEphpbb so laravel homestead prevents this from working with symfony 3.x. Same issue as with sami: it requires symfony 2.x. And homestead 3.x requires PHP 5.5.9

@marc1706
Copy link
Member Author

@nicolas-grekas I guess this was just mentioned by @Nicofuma as a heads up. I can see that this was reverted. Does this also mean it has been reverted for the 3.x versions of symfony?

@iMattPro
Copy link
Member

@marc1706 So can we just update the homestead dep, even though it uses PHP 5.5.9? I mean, the vagrant component is meant for local use by developers so I'm not sure it needs to be strictly limited by phpBB's PHP requirement.

@marc1706
Copy link
Member Author

True, but it might be good to change the PHP version limit again.

@iMattPro
Copy link
Member

Ah yes, well for 3.3 I'm pretty sure @Nicofuma wanted it bumped up to 5.5.x anyways.

marc1706 added 5 commits July 23, 2016 17:13
Removed sami as it doesn't have a version compatible
with symfony 3.x.

PHPBB3-14670
In this specific case, the mock container builder is used which does not
even support setting the scope.

PHPBB3-14670
marc1706 added 2 commits July 23, 2016 17:54
This seems to cause issues with the UI tests as the backed up
static web driver does not seem to be properly initialized.

PHPBB3-14670
The prototype scope was deprecated in symfony 2.8 and removed in 3.0.

PHPBB3-14670
@marc1706
Copy link
Member Author

Removed WIP label

@marc1706 marc1706 removed the WIP 🚧 label Jul 25, 2016
@marc1706
Copy link
Member Author

Should probably add the PHP 7.1 builds to 3.2, too, once the s9e text formatter gets updated.

@Nicofuma
Copy link
Member

👍 and we need to discuss 3.3 PHP target version

@CHItA CHItA merged commit 8327224 into phpbb:master Jul 29, 2016
@marc1706 marc1706 deleted the ticket/14670 branch July 29, 2016 16:32
@marc1706 marc1706 modified the milestones: 4.0.0-a1, 3.3.0-b1 May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0