-
-
Notifications
You must be signed in to change notification settings - Fork 981
[ticket/14670] Use symfony 3.x in master branch #4350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -25,41 +25,40 @@ | |||
"phpbb/phpbb-core": "self.version" | |||
}, | |||
"require": { | |||
"php": ">=5.4,<7.1", | |||
"php": ">=5.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symfony 3.1 needs PHP 5.5.9
I just pushed this to have tests running. This will need a few more fixes probably. |
another BC break to take in account: symfony/symfony#19114 |
Ok. We should start a page of BC breaks in symfony so we don't loose track of this. I also still need to figure out what happened to the stupid UI tests. |
@Nicofuma can you please explain how the PR you linked is affecting you? |
@VSEphpbb so laravel homestead prevents this from working with symfony 3.x. Same issue as with sami: it requires symfony 2.x. And homestead 3.x requires PHP 5.5.9 |
@nicolas-grekas I guess this was just mentioned by @Nicofuma as a heads up. I can see that this was reverted. Does this also mean it has been reverted for the 3.x versions of symfony? |
@marc1706 So can we just update the homestead dep, even though it uses PHP 5.5.9? I mean, the vagrant component is meant for local use by developers so I'm not sure it needs to be strictly limited by phpBB's PHP requirement. |
True, but it might be good to change the PHP version limit again. |
Ah yes, well for 3.3 I'm pretty sure @Nicofuma wanted it bumped up to 5.5.x anyways. |
Removed sami as it doesn't have a version compatible with symfony 3.x. PHPBB3-14670
In this specific case, the mock container builder is used which does not even support setting the scope. PHPBB3-14670
PHPBB3-14670
This seems to cause issues with the UI tests as the backed up static web driver does not seem to be properly initialized. PHPBB3-14670
The prototype scope was deprecated in symfony 2.8 and removed in 3.0. PHPBB3-14670
Removed WIP label |
Should probably add the PHP 7.1 builds to 3.2, too, once the s9e text formatter gets updated. |
👍 and we need to discuss 3.3 PHP target version |
Checklist:
https://tracker.phpbb.com/browse/PHPBB3-14670