8000 Adding support of phpstan/phpdoc-parser ^2.0 is a breaking change · Issue #391 · phpDocumentor/ReflectionDocBlock · GitHub
[go: up one dir, main page]

Skip to content
Adding support of phpstan/phpdoc-parser ^2.0 is a breaking change #391
@patrickbroens

Description

@patrickbroens

In v5.6.0 support for phpstan/phpdoc-parser version 2.0 has been added. This change should have triggered a new major version, 6.0.0, instead of a new minor version.

The reason for this is the object PHPStan\PhpDocParser\Lexer\Lexer has changed, including the constructor parameters. In version 1 the constructor parameter expects a boolean, but in version 2 NOT a boolean is expected, but the object PHPStan\PhpDocParser\ParserConfig, which is a breaking change.

The Lexer is constructed in phpDocumentor\Reflection\DocBlock\Tags\Factory\AbstractPHPStanFactory on line 47, where the parameter is still a boolean and not the expected object.

Please remove the phpstan/phpdoc-parser version 2.0 support from the version 5 and start working on a new major version 6, because a lot is breaking currently.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0