fix: throw exception on stream_socket_enable_crypto() warning

ramunasd · ramunasd · commit 2e18096da068 · 2024-02-06T21:58:17.000+02:00
diff --git a/PhpAmqpLib/Wire/IO/StreamIO.php b/PhpAmqpLib/Wire/IO/StreamIO.php
@@ -139,7 +139,7 @@ public function connect()
 
         $options = stream_context_get_options($context);
         if (isset($options['ssl']['crypto_method'])) {
-            $this->enable_crypto();
+            $this->enableCrypto();
         }
 
         $this->heartbeat = $this->initial_heartbeat;
@@ -432,16 +432,28 @@ protected function extract_error_code($message)
         return 0;
     }
 
-    private function enable_crypto(): void
+    /**
+     * @throws AMQPIOException
+     */
+    private function enableCrypto(): void
     {
         $timeout_at = time() + ($this->read_timeout + $this->write_timeout) * 2; // 2 round-trips during handshake
 
-        do {
-            $enabled = stream_socket_enable_crypto($this->sock, true);
-        } while ($enabled !== true && time() < $timeout_at);
+        try {
+            $this->setErrorHandler();
+            do {
+                $enabled = stream_socket_enable_crypto($this->sock, true);
+                $this->throwOnError();
+                usleep(1e4);
+            } while ($enabled === 0 && time() < $timeout_at);
+        } catch (\ErrorException $exception) {
+            throw new AMQPIOException($exception->getMessage(), $exception->getCode(), $exception);
+        } finally {
+            $this->restoreErrorHandler();
+        }
 
         if ($enabled !== true) {
-            throw new AMQPIOException('Can not enable crypto');
+            throw new AMQPIOException('Could not enable socket crypto');
         }
     }
 }
diff --git a/tests/Unit/Connection/AMQPConnectionConfigTest.php b/tests/Unit/Connection/AMQPConnectionConfigTest.php
@@ -50,7 +50,7 @@ public function external_auth_with_user_credentials()
     public function secure_with_incorrect_crypto_method()
     {
         $this->expectException(AMQPIOException::class);
-        $this->expectExceptionMessage('Can not enable crypto');
+        $this->expectExceptionMessage('stream_socket_enable_crypto(): SSL: Connection reset by peer');
 
         $cert_dir = realpath(__DIR__ . "/../../certs");
         $config = new AMQPConnectionConfig();

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function external_auth_with_user_credentials()`
`50`	`50`	`public function secure_with_incorrect_crypto_method()`
`51`	`51`	`{`
`52`	`52`	`$this->expectException(AMQPIOException::class);`
`53`		`- $this->expectExceptionMessage('Can not enable crypto');`
	`53`	`+ $this->expectExceptionMessage('stream_socket_enable_crypto(): SSL: Connection reset by peer');`
`54`	`54`
`55`	`55`	`$cert_dir = realpath(__DIR__ . "/../../certs");`
`56`	`56`	`$config = new AMQPConnectionConfig();`