Does not throw when parsing a Remote with no url

nulltoken · nulltoken · commit 27dd2c05e72d · 2013-08-22T20:22:37.000+02:00
Fix libgit2#484
diff --git a/LibGit2Sharp.Tests/RemoteFixture.cs b/LibGit2Sharp.Tests/RemoteFixture.cs
@@ -40,7 +40,7 @@ public void CanEnumerateTheRemotes()
                     count++;
                 }
 
-                Assert.Equal(1, count);
+                Assert.Equal(2, count);
             }
         }
 
@@ -155,5 +155,16 @@ public void CanTellIfARemoteNameIsValid(string refname, bool expectedResult)
                 Assert.Equal(expectedResult, repo.Network.Remotes.IsValidName(refname));
             }
         }
+
+        [Fact]
+        public void DoesNotThrowWhenARemoteHasNoUrlSet()
+        {
+            using (var repo = new Repository(StandardTestRepoPath))
+            {
+                var noUrlRemote = repo.Network.Remotes["no_url"];
+                Assert.NotNull(noUrlRemote);
+                Assert.Equal(string.Empty, noUrlRemote.Url);
+            }
+        }
     }
 }
diff --git a/LibGit2Sharp.Tests/Resources/testrepo_wd/dot_git/config b/LibGit2Sharp.Tests/Resources/testrepo_wd/dot_git/config
@@ -9,6 +9,9 @@
 [remote "origin"]
 	fetch = +refs/heads/*:refs/remotes/origin/*
 	url = c:/GitHub/libgit2sharp/Resources/testrepo.git
+[remote "no_url"]
+	url =
+	fetch = +refs/heads/*:refs/remotes/no_url/*
 [branch "master"]
 	remote = origin
 	merge = refs/heads/master

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public void CanEnumerateTheRemotes()`
`40`	`40`	`count++;`
`41`	`41`	`}`
`42`	`42`
`43`		`- Assert.Equal(1, count);`
	`43`	`+ Assert.Equal(2, count);`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`@@ -155,5 +155,16 @@ public void CanTellIfARemoteNameIsValid(string refname, bool expectedResult)`
`155`	`155`	`Assert.Equal(expectedResult, repo.Network.Remotes.IsValidName(refname));`
`156`	`156`	`}`
`157`	`157`	`}`
	`158`	`+`
	`159`	`+ [Fact]`
	`160`	`+ public void DoesNotThrowWhenARemoteHasNoUrlSet()`
	`161`	`+ {`
	`162`	`+ using (var repo = new Repository(StandardTestRepoPath))`
	`163`	`+ {`
	`164`	`+ var noUrlRemote = repo.Network.Remotes["no_url"];`
	`165`	`+ Assert.NotNull(noUrlRemote);`
	`166`	`+ Assert.Equal(string.Empty, noUrlRemote.Url);`
	`167`	`+ }`
	`168`	`+ }`
`158`	`169`	`}`
`159`	`170`	`}`