Merge #300: Add HTTPS to supported RPC Proxy protocols

petertodd · petertodd · commit 101bde56e1c2 · 2024-08-06T10:20:50.000Z
2fabb36 Add HTTPS to supported RPC Proxy protocols (mhh) Pull request description: Allows using HTTPS URLs when configuring a Bitcoin proxy: ```python import bitcoin.rpc btc_proxy = bitcoin.rpc.Proxy( service_url="https://<some-rpc-id>.btc.quiknode.pro/<api-secret>" ) ``` Top commit has no ACKs. Tree-SHA512: 190dd5ce30e4a31da81c5a06161739b10e34279458821fa0c4be952033d6aaf7a0380e3edecd49c6b9f0984f6d62488e9f5be1efe50f683bab5edca0c2d13752
diff --git a/bitcoin/rpc.py b/bitcoin/rpc.py
@@ -205,11 +205,14 @@ def __init__(self,
         self.__service_url = service_url
         self.__url = urlparse.urlparse(service_url)
 
-        if self.__url.scheme not in ('http',):
+        if self.__url.scheme not in ('http', 'https'):
             raise ValueError('Unsupported URL scheme %r' % self.__url.scheme)
 
         if self.__url.port is None:
-            port = httplib.HTTP_PORT
+            if self.__url.scheme == 'https':
+                port = httplib.HTTPS_PORT
+            else:
+                port = httplib.HTTP_PORT
         else:
             port = self.__url.port
         self.__id_count = 0
@@ -223,8 +226,12 @@ def __init__(self,
         if connection:
             self.__conn = connection
         else:
-            self.__conn = httplib.HTTPConnection(self.__url.hostname, port=port,
-                                                 timeout=timeout)
+            if self.__url.scheme == 'https':
+                self.__conn = httplib.HTTPSConnection(self.__url.hostname, port=port,
+                                                      timeout=timeout)
+            else:
+                self.__conn = httplib.HTTPConnection(self.__url.hostname, port=port,
+                                                     timeout=timeout)
 
     def _call(self, service_name, *args):
         self.__id_count += 1
