[Validator] Extend and fix DateValidator & TimeValidator tests

stloyd · stloyd · commit d7c9644d291f · 2011-10-07T10:47:59.000+02:00
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/DateValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/DateValidatorTest.php
@@ -40,7 +40,7 @@ public function testEmptyStringIsValid()
 
     public function testDateTimeClassIsValid()
     {
-        $this->validator->isValid(new \DateTime(), new Date());
+        $this->assertTrue($this->validator->isValid(new \DateTime(), new Date()));
     }
 
     public function testExpectsStringCompatibleType()
@@ -79,6 +79,8 @@ public function getInvalidDates()
     {
         return array(
             array('foobar'),
+            array('foobar 2010-13-01'),
+            array('2010-13-01 foobar'),
             array('2010-13-01'),
             array('2010-04-32'),
             array('2010-02-29'),
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/TimeValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/TimeValidatorTest.php
@@ -40,7 +40,7 @@ public function testEmptyStringIsValid()
 
     public function testDateTimeClassIsValid()
     {
-        $this->validator->isValid(new \DateTime(), new Time());
+        $this->assertTrue($this->validator->isValid(new \DateTime(), new Time()));
     }
 
     public function testExpectsStringCompatibleType()
@@ -79,6 +79,8 @@ public function getInvalidTimes()
     {
         return array(
             array('foobar'),
+            array('foobar 12:34:56'),
+            array('12:34:56 foobar'),
             array('00:00'),
             array('24:00:00'),
             array('00:60:00'),

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function testEmptyStringIsValid()`
`40`	`40`
`41`	`41`	`public function testDateTimeClassIsValid()`
`42`	`42`	`{`
`43`		`- $this->validator->isValid(new \DateTime(), new Date());`
	`43`	`+ $this->assertTrue($this->validator->isValid(new \DateTime(), new Date()));`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public function testExpectsStringCompatibleType()`
`@@ -79,6 +79,8 @@ public function getInvalidDates()`
`79`	`79`	`{`
`80`	`80`	`return array(`
`81`	`81`	`array('foobar'),`
	`82`	`+ array('foobar 2010-13-01'),`
	`83`	`+ array('2010-13-01 foobar'),`
`82`	`84`	`array('2010-13-01'),`
`83`	`85`	`array('2010-04-32'),`
`84`	`86`	`array('2010-02-29'),`