8000 psql: Remove PARTITION BY clause in tab completion for unlogged tables · petergeoghegan/postgres@3614995 · GitHub
[go: up one dir, main page]
Skip to content

Commit 3614995

Browse files
michaelpqmichaelpq
committed
psql: Remove PARTITION BY clause in tab completion for unlogged tables
CREATE UNLOGGED TABLE was still being recommended by psql's tab completion as a possible pattern, but the backend is rejecting this option since e2bab2d. Reported-by: Shinya Kato <shinya11.kato@gmail.com> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Shinya Kato <shinya11.kato@gmail.com> Discussion: https://postgr.es/m/CAOzEurQZ1a+6d1K8b=+Ww1NFQVwAt9KSCQsBWXYBaPnYCenK3g@mail.gmail.com
1 parent 137935b commit 3614995

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

‎src/bin/psql/tab-complete.in.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3664,9 +3664,10 @@ match_previous_words(int pattern_id,
36643664
TailMatches("CREATE", "TEMP|TEMPORARY|UNLOGGED", "TABLE", MatchAny, "(*)", "AS"))
36653665< 7780 /td>
COMPLETE_WITH("EXECUTE", "SELECT", "TABLE", "VALUES", "WITH");
36663666
/* Complete CREATE TABLE name (...) with supported options */
3667-
else if (TailMatches("CREATE", "TABLE", MatchAny, "(*)") ||
3668-
TailMatches("CREATE", "UNLOGGED", "TABLE", MatchAny, "(*)"))
3667+
else if (TailMatches("CREATE", "TABLE", MatchAny, "(*)"))
36693668
COMPLETE_WITH("AS", "INHERITS (", "PARTITION BY", "USING", "TABLESPACE", "WITH (");
3669+
else if (TailMatches("CREATE", "UNLOGGED", "TABLE", MatchAny, "(*)"))
3670+
COMPLETE_WITH("AS", "INHERITS (", "USING", "TABLESPACE", "WITH (");
36703671
else if (TailMatches("CREATE", "TEMP|TEMPORARY", "TABLE", MatchAny, "(*)"))
36713672
COMPLETE_WITH("AS", "INHERITS (", "ON COMMIT", "PARTITION BY", "USING",
36723673
"TABLESPACE", "WITH (");

0 commit comments

Comments
 (0)
0